From: Tommy Christensen <tommy.christensen@tpack.net>
To: Olaf Kirch <okir@suse.de>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] Deadlock in af_packet/packet_rcv
Date: Tue, 30 Nov 2004 12:56:30 +0100 [thread overview]
Message-ID: <41AC5FEE.8020707@tpack.net> (raw)
In-Reply-To: <20041130114535.GF16970@suse.de>
Olaf Kirch wrote:
> On Tue, Nov 30, 2004 at 12:31:50PM +0100, Tommy Christensen wrote:
>
>>I still don't agree with the conclusion, though. The spin_lock_bh()
>>is changed to a local_bh_disable() and an optional spin_lock().
>>That should not lead to what you are seeing!
>
>
> Well, the code in 2.6.9 has
>
> #define HARD_TX_LOCK(dev, cpu) { \
> if ((dev->features & NETIF_F_LLTX) == 0) { \
> spin_lock(&dev->xmit_lock); \
> dev->xmit_lock_owner = cpu; \
> } \
> }
>
> i.e. there's no local_bh_disable at all - adding the local_bh_disable
> was the whole point of my patch. Or did you refer to a different spinlock?
The local_bh_disable() is called earlier in dev_queue_xmit(), and
is held across the whole HARD_TX_LOCK/dev_queue_xmit_nit/
hard_start_xmit/HARD_TX_UNLOCK sequence.
-Tommy
next prev parent reply other threads:[~2004-11-30 11:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-25 20:55 [PATCH] Deadlock in af_packet/packet_rcv Olaf Kirch
2004-11-30 4:02 ` David S. Miller
2004-11-30 10:48 ` Olaf Kirch
2004-11-30 9:32 ` Tommy Christensen
2004-11-30 11:01 ` Olaf Kirch
2004-11-30 11:31 ` Tommy Christensen
2004-11-30 11:45 ` Olaf Kirch
2004-11-30 11:56 ` Tommy Christensen [this message]
2004-11-30 21:07 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41AC5FEE.8020707@tpack.net \
--to=tommy.christensen@tpack.net \
--cc=netdev@oss.sgi.com \
--cc=okir@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).