From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [PATCH] b44: allow ethtool get_settings when down
Date: Thu, 02 Dec 2004 06:25:09 -0500 [thread overview]
Message-ID: <41AEFB95.8000100@pobox.com> (raw)
In-Reply-To: <20041129094523.3185c64c@zqx3.pdx.osdl.net>
Stephen Hemminger wrote:
> The FC and Suse startup scripts use ethtool to check for link present. This has
> problems on my laptop with Broadcom because it quieries settings before
> bringing link up. The problem is driver returns EAGAIN when queried for
> settings but not up. Just go ahead and return values anyway, the supported and link
> state values will be correct, speed will end up being 10BaseT/Half which is a
> reasonable default.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> diff -Nru a/drivers/net/b44.c b/drivers/net/b44.c
> --- a/drivers/net/b44.c 2004-11-29 09:41:27 -08:00
> +++ b/drivers/net/b44.c 2004-11-29 09:41:27 -08:00
> @@ -1487,8 +1487,6 @@
> {
> struct b44 *bp = netdev_priv(dev);
>
> - if (!(bp->flags & B44_FLAG_INIT_COMPLETE))
> - return -EAGAIN;
> cmd->supported = (SUPPORTED_Autoneg);
> cmd->supported |= (SUPPORTED_100baseT_Half |
> SUPPORTED_100baseT_Full |
I'm not so sure about this one...
This sounds like working around stupid userland in the kernel?
Jeff
next prev parent reply other threads:[~2004-12-02 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-29 17:45 [PATCH] b44: allow ethtool get_settings when down Stephen Hemminger
2004-12-02 11:25 ` Jeff Garzik [this message]
2004-12-02 17:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41AEFB95.8000100@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).