netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Daniele Venzano <webvenza@libero.it>
Cc: NetDev <netdev@oss.sgi.com>
Subject: Re: [PATCH 1/5] sis900 printk and stack usage audit
Date: Sat, 11 Dec 2004 14:04:08 -0500	[thread overview]
Message-ID: <41BB44A8.7000906@pobox.com> (raw)
In-Reply-To: <20041208110156.GB31707@picchio.gall.it>

Daniele Venzano wrote:
> Audit of current printk() calls
> Changed debug levels to 0,1,2,3 as follows:
>  0 No debug
>  1 load/probe/unload/suspend/resume stuff
>  2 rx/tx errors
>  3 rx/tx packets and every interrupt are logged (very verbose)
> Debug levels are incremental
> Removed double printing of version string in module_init and in sis900_probe
> Made the sis900_debug parameter modifiable at runtime

Debug levels are standardized, please follow the standard.

All messages are bitmapped.  See NETIF_MSG_* and netif_msg_* in 
include/linux/netdevice.h.

Given the standard 'debug' module parameter, which takes a value from 
0-N (where N==10 or so), the driver uses netif_msg_init() to construct 
the bitmap of messages to be enabled.

	Jeff

  reply	other threads:[~2004-12-11 19:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-08 10:47 [PATCH 0/5] sis900 printk and stack usage audit Daniele Venzano
2004-12-08 11:01 ` [PATCH 1/5] " Daniele Venzano
2004-12-11 19:04   ` Jeff Garzik [this message]
2004-12-11 19:06   ` Jeff Garzik
2004-12-12  8:15     ` Daniele Venzano
2004-12-08 11:04 ` [PATCH 2/5] " Daniele Venzano
2004-12-11 19:09   ` Jeff Garzik
2004-12-12  8:19     ` Daniele Venzano
2004-12-08 11:06 ` [PATCH 3/5] " Daniele Venzano
2004-12-11 19:09   ` Jeff Garzik
2004-12-08 11:08 ` [PATCH 4/5] " Daniele Venzano
2004-12-11 19:11   ` Jeff Garzik
2004-12-12  8:23     ` Daniele Venzano
2004-12-08 11:10 ` [PATCH 5/5] " Daniele Venzano
2004-12-11 19:11   ` Jeff Garzik
2004-12-12  8:27     ` Daniele Venzano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41BB44A8.7000906@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=webvenza@libero.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).