From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: jamal <hadi@cyberus.ca>, "David S. Miller" <davem@davemloft.net>,
netdev@oss.sgi.com
Subject: Re: [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs
Date: Mon, 20 Dec 2004 09:06:06 +0100 [thread overview]
Message-ID: <41C687EE.1090205@trash.net> (raw)
In-Reply-To: <20041219203641.GL17998@postel.suug.ch>
Thomas Graf wrote:
> * jamal <1103487827.1048.188.camel@jzny.localdomain> 2004-12-19 15:23
>
>>If the qdisc at that level muddies the packet thats fair game - thats
>>what goes out on the wire. So we should leave the code as is.
>
>
> Agreed for egress but I think it is needed for stuff like IMQ. It's
> debatable whether we should take care of IMQ and alike though.
>
You shouldn't care about IMQ, but we still need to copy the packet
before modifying it if the data is shared. Otherwise we have a race
on SMP with AF_PACKET sockets, depending on when the packet is read
it can be either modified or not.
Converting dsmark to an action sounds like the best long-term solution.
Regards
Patrick
next prev parent reply other threads:[~2004-12-20 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-18 17:00 [PATCH] PKT_SCHED: dsmark must take care of shared/cloned skbs Thomas Graf
2004-12-18 21:00 ` Thomas Graf
2004-12-19 20:23 ` jamal
2004-12-19 20:36 ` Thomas Graf
2004-12-19 22:53 ` jamal
2004-12-19 23:18 ` Thomas Graf
2004-12-20 8:06 ` Patrick McHardy [this message]
2004-12-20 14:13 ` jamal
2004-12-21 1:02 ` David S. Miller
2004-12-22 13:14 ` jamal
2004-12-22 13:50 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C687EE.1090205@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).