From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>,
netdev@oss.sgi.com
Subject: Re: [PATCH] PKT_SCHED: Provide compat policer stats in action policer
Date: Tue, 21 Dec 2004 11:11:48 +0100 [thread overview]
Message-ID: <41C7F6E4.1010507@trash.net> (raw)
In-Reply-To: <1103552830.1049.355.camel@jzny.localdomain>
jamal wrote:
> I havent looked closely at tcng although Werner has showed it to me a
> few times (may be under influence). We need to pick one or other test
> setup. I dont care if its what I have, tcng or what Thomas has.
> I just stared quickly at what Thomas has and realize its not really
> automated. In my case it is easier because i can click on the proverbial
> one-button and run 20 tests (including a subset of the policer ones)
> and even capturing tcpdumps. I have attached a sample testcase.
> They are harder to create and require the environment i have.
> But once you create them, you should be saying "go" - go do something
> and come back and get results.
> Whatever we end up having, my preference would be something along those
> lines,
tcsim has one major advantage, you can test the actual
scheduling algorithms for their behaviour under very
controlled conditions. It gave me a lot more confidence
when replacing the HFSC lists by rbtrees. But, as Thomas
notes, it does all its tests in userspace, which might
not be ideal for things besides scheduling algorithms.
So a combination of both seems to be best.
Regards
Patrick
next prev parent reply other threads:[~2004-12-21 10:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-15 13:01 [PATCH] PKT_SCHED: Provide compat policer stats in action policer Thomas Graf
2004-12-15 14:09 ` jamal
2004-12-15 15:22 ` Thomas Graf
2004-12-15 15:42 ` Patrick McHardy
2004-12-19 19:24 ` jamal
2004-12-20 10:17 ` Patrick McHardy
2004-12-20 14:03 ` Thomas Graf
2004-12-20 14:32 ` jamal
2004-12-20 14:27 ` jamal
2004-12-21 0:16 ` Thomas Graf
2004-12-22 13:10 ` jamal
2004-12-22 13:32 ` Thomas Graf
2004-12-22 13:54 ` jamal
2004-12-21 10:11 ` Patrick McHardy [this message]
2004-12-20 23:51 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C7F6E4.1010507@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).