From: Patrick McHardy <kaber@trash.net>
To: jamal <hadi@cyberus.ca>
Cc: Maillist netdev <netdev@oss.sgi.com>
Subject: [PATCH PKT_SCHED 8/17]: Return proper error codes in tcf_gact_init
Date: Thu, 30 Dec 2004 04:40:05 +0100 [thread overview]
Message-ID: <41D37895.4010801@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 45 bytes --]
Return proper error codes in tcf_gact_init.
[-- Attachment #2: 08.diff --]
[-- Type: text/x-patch, Size: 1166 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/12/30 02:29:53+01:00 kaber@coreworks.de
# [PKT_SCHED]: Return proper error codes in tcf_gact_init
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/gact.c
# 2004/12/30 02:29:47+01:00 kaber@coreworks.de +4 -7
# [PKT_SCHED]: Return proper error codes in tcf_gact_init
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/sched/gact.c b/net/sched/gact.c
--- a/net/sched/gact.c 2004-12-30 04:01:28 +01:00
+++ b/net/sched/gact.c 2004-12-30 04:01:28 +01:00
@@ -83,12 +83,9 @@
int ret = 0;
if (rtattr_parse(tb, TCA_GACT_MAX, RTA_DATA(rta), RTA_PAYLOAD(rta)) < 0)
- return -1;
-
- if (tb[TCA_GACT_PARMS - 1] == NULL) {
- printk("BUG: tcf_gact_init called with NULL params\n");
- return -1;
- }
+ return -EINVAL;
+ if (tb[TCA_GACT_PARMS - 1] == NULL)
+ return -EINVAL;
parm = RTA_DATA(tb[TCA_GACT_PARMS - 1]);
#ifdef CONFIG_GACT_PROB
@@ -99,7 +96,7 @@
if (p == NULL) {
p = tcf_hash_create(parm, est, a, sizeof(*p), ovr, bind);
if (p == NULL)
- return -1;
+ return -ENOMEM;
else {
p->refcnt = 1;
ret = 1;
reply other threads:[~2004-12-30 3:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D37895.4010801@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).