netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: jamal <hadi@cyberus.ca>
Cc: Maillist netdev <netdev@oss.sgi.com>
Subject: [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action
Date: Thu, 30 Dec 2004 04:41:51 +0100	[thread overview]
Message-ID: <41D378FF.3080205@trash.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

Disable broken override bits in pedit action. It misses
locking and needs to allocate new memory if nkeys increases.
Also disable it for now.


[-- Attachment #2: 17.diff --]
[-- Type: text/x-patch, Size: 780 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/12/30 03:56:27+01:00 kaber@coreworks.de 
#   [PKT_SCHED]: Disable broken override bits in pedit action
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
# net/sched/pedit.c
#   2004/12/30 03:56:20+01:00 kaber@coreworks.de +2 -0
#   [PKT_SCHED]: Disable broken override bits in pedit action
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
diff -Nru a/net/sched/pedit.c b/net/sched/pedit.c
--- a/net/sched/pedit.c	2004-12-30 04:02:10 +01:00
+++ b/net/sched/pedit.c	2004-12-30 04:02:10 +01:00
@@ -83,6 +83,8 @@
 
 	ret = -EEXIST;
 	if (ovr) {
+		/* FIXME: no locking, larger memory area might be required */
+		return -EOPNOTSUPP;
 		ret = 0;
 override:
 		p->flags = parm->flags;

             reply	other threads:[~2004-12-30  3:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-30  3:41 Patrick McHardy [this message]
2004-12-30 13:17 ` [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action jamal
2004-12-30 13:25   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41D378FF.3080205@trash.net \
    --to=kaber@trash.net \
    --cc=hadi@cyberus.ca \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).