* [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action
@ 2004-12-30 3:41 Patrick McHardy
2004-12-30 13:17 ` jamal
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2004-12-30 3:41 UTC (permalink / raw)
To: jamal; +Cc: Maillist netdev
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
Disable broken override bits in pedit action. It misses
locking and needs to allocate new memory if nkeys increases.
Also disable it for now.
[-- Attachment #2: 17.diff --]
[-- Type: text/x-patch, Size: 780 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/12/30 03:56:27+01:00 kaber@coreworks.de
# [PKT_SCHED]: Disable broken override bits in pedit action
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/pedit.c
# 2004/12/30 03:56:20+01:00 kaber@coreworks.de +2 -0
# [PKT_SCHED]: Disable broken override bits in pedit action
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/sched/pedit.c b/net/sched/pedit.c
--- a/net/sched/pedit.c 2004-12-30 04:02:10 +01:00
+++ b/net/sched/pedit.c 2004-12-30 04:02:10 +01:00
@@ -83,6 +83,8 @@
ret = -EEXIST;
if (ovr) {
+ /* FIXME: no locking, larger memory area might be required */
+ return -EOPNOTSUPP;
ret = 0;
override:
p->flags = parm->flags;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action
2004-12-30 3:41 [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action Patrick McHardy
@ 2004-12-30 13:17 ` jamal
2004-12-30 13:25 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: jamal @ 2004-12-30 13:17 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Maillist netdev
On Wed, 2004-12-29 at 22:41, Patrick McHardy wrote:
> Disable broken override bits in pedit action. It misses
> locking and needs to allocate new memory if nkeys increases.
> Also disable it for now.
>
There are a couple of these that you have (ipt being other). Could you
just add a check for size before returning -EOPNOTSUPP?
Example:
if (ovr)
if (p->nkeys != parm->nkeys)
return -EOPNOTSUPP;
This way if they are of the same size then things should work as is
and my testcases dont break. Now if you feel more gracious, go ahead and
fix them ;->
> ret = -EEXIST;
> if (ovr) {
> + /* FIXME: no locking, larger memory area might be required */
> + return -EOPNOTSUPP;
> ret = 0;
> override:
> p->flags = parm->flags;
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action
2004-12-30 13:17 ` jamal
@ 2004-12-30 13:25 ` Patrick McHardy
0 siblings, 0 replies; 3+ messages in thread
From: Patrick McHardy @ 2004-12-30 13:25 UTC (permalink / raw)
To: hadi; +Cc: Maillist netdev
jamal wrote:
> This way if they are of the same size then things should work as is
> and my testcases dont break. Now if you feel more gracious, go ahead and
> fix them ;->
Yes, this patch was silly, I should have just fixed it.
I'll revert the patch and fix it.
Regards
Patrick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-12-30 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-12-30 3:41 [PATCH PKT_SCHED 17/17]: Disable broken override bits in pedit action Patrick McHardy
2004-12-30 13:17 ` jamal
2004-12-30 13:25 ` Patrick McHardy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).