From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: jamal <hadi@cyberus.ca>, Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH PKT_SCHED 11/17]: Remove checks for impossible conditions in ipt action
Date: Thu, 30 Dec 2004 15:25:13 +0100 [thread overview]
Message-ID: <41D40FC9.6060902@trash.net> (raw)
In-Reply-To: <20041230134029.GX32419@postel.suug.ch>
Thomas Graf wrote:
> * Patrick McHardy <41D378AB.70204@trash.net> 2004-12-30 04:40
>
>>- if (a == NULL || rta == NULL ||
>>- rtattr_parse(tb, TCA_IPT_MAX, RTA_DATA(rta), RTA_PAYLOAD(rta)) < 0)
>>+ if (rtattr_parse(tb, TCA_IPT_MAX, RTA_DATA(rta), RTA_PAYLOAD(rta)) < 0)
>> return -1;
>
>
> You might want to use rtattr_parse_nested here (see patch 1 of my latest
> patchset)
>
> if (rtattr_parse_nested(tb, TCA_IPT_MAX, rta) < 0)
>
> Purely cosmetic though. It gives a slightly better hint on what is being
> done.
We can do this once your changes are merged (I'll review
them later today). For now I prefer to leave it this way
so I can work on a vanilla tree.
Regards
Patrick
prev parent reply other threads:[~2004-12-30 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 3:40 [PATCH PKT_SCHED 11/17]: Remove checks for impossible conditions in ipt action Patrick McHardy
2004-12-30 13:40 ` Thomas Graf
2004-12-30 14:25 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D40FC9.6060902@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).