From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Patrick McHardy <kaber@trash.net>
Cc: hadi@cyberus.ca, Maillist netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes
Date: Thu, 30 Dec 2004 20:12:04 -0200 [thread overview]
Message-ID: <41D47D34.1000708@conectiva.com.br> (raw)
In-Reply-To: <41D3F5EC.9050808@trash.net>
Patrick McHardy wrote:
> jamal wrote:
>
>> Patrick,
>> Thanks for this cleanup.
>>
>> Questions/comments:
>>
>> 1)compiler or style issue?
>>
>> You have a few of fixes from
>>
>> a)
>> if (..){
>> single statement here;
>> }
>>
>> to:
>> if (..)
>> single statement here;
>>
>> I always add an extra pair of brace
>> for lazy reasons (in the back of my mind: incase i want to add another
>> statement ;->).
>
>
> Just cleanup, I prefer not to waste too many lines. Saving
> space increases readability.
Agreed, whenever I have the chance, I remove such bloat ;)
- Arnaldo
prev parent reply other threads:[~2004-12-30 22:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-30 3:39 [PATCH PKT_SCHED 0/17]: tc action cleanup + fixes Patrick McHardy
2004-12-30 4:56 ` jamal
2004-12-30 12:34 ` Patrick McHardy
2004-12-30 13:30 ` jamal
2004-12-30 14:16 ` Patrick McHardy
2004-12-30 16:10 ` Patrick McHardy
2004-12-31 4:45 ` jamal
2004-12-31 9:54 ` Patrick McHardy
2004-12-31 11:26 ` Thomas Graf
2004-12-31 15:00 ` jamal
2004-12-30 22:12 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D47D34.1000708@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).