netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@oss.sgi.com, Wichert Akkerman <wichert@wiggy.net>
Subject: Re: patch: tunnels not setting inputdev
Date: Sat, 01 Jan 2005 17:10:47 +0100	[thread overview]
Message-ID: <41D6CB87.8040205@trash.net> (raw)
In-Reply-To: <1104523892.1047.338.camel@jzny.localdomain>

jamal wrote:

>>For the remaining changes, why not simply set
>>input_dev in netif_receive_skb before the call to ing_filter ?
> 
> You want to be able to filter on indev at ingress - it is safer for
> whoever calls netif_rx() to do the setting. The packet could be looped
> from egress multiple times as well (redirected).

Currently input_dev is set in eth_type_trans, ppp_generic and the
mirred action. With your patch we have a couple of drivers more,
but this still leaves lots of non-ethernet drivers that don't set
input_dev. A centralized solutions seems much better to me than
adding this to every single driver. I can't see the problem with
redirected packets, just set skb->input_dev = skb->dev in
netif_receive_skb, this should have exactly the same effect as
setting it in the drivers or the mirred action.

Regards
Patrick

  reply	other threads:[~2005-01-01 16:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-31 17:16 patch: tunnels not setting inputdev jamal
2004-12-31 18:02 ` Patrick McHardy
2004-12-31 20:11   ` jamal
2005-01-01 16:10     ` Patrick McHardy [this message]
2005-01-01 23:33       ` jamal
2005-01-02  0:24         ` Patrick McHardy
2005-01-03 14:46           ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41D6CB87.8040205@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=netdev@oss.sgi.com \
    --cc=wichert@wiggy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).