From: Jeff Garzik <jgarzik@pobox.com>
To: Johannes Erdfelt <johannes@erdfelt.com>
Cc: netdev@oss.sgi.com
Subject: Re: [RFC] tulip VLAN support
Date: Wed, 05 Jan 2005 17:12:57 -0500 [thread overview]
Message-ID: <41DC6669.9090407@pobox.com> (raw)
In-Reply-To: <20050105193425.GY18847@sventech.com>
Johannes Erdfelt wrote:
> @@ -259,7 +259,7 @@
> #define RX_RING_SIZE 128
> #define MEDIA_MASK 31
>
> -#define PKT_BUF_SZ 1536 /* Size of each temporary Rx buffer. */
> +#define PKT_BUF_SZ 1540 /* Size of each temporary Rx buffer. */
This is the reason why the tulip "vlan" patch is continually rejected.
You shouldn't need to increase this constant, but rather follow the
other "large MTU" driver conversions.
Donald Becker's tulip.c (on which the kernel tulip is based) supports
proper MTU changing: ftp://ftp.scyld.com/pub/network/
Jeff
next prev parent reply other threads:[~2005-01-05 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-05 19:34 [RFC] tulip VLAN support Johannes Erdfelt
2005-01-05 22:12 ` Jeff Garzik [this message]
2005-01-05 22:17 ` Ben Greear
2005-01-05 22:31 ` Johannes Erdfelt
2005-01-05 22:45 ` Jeff Garzik
2005-01-05 22:56 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41DC6669.9090407@pobox.com \
--to=jgarzik@pobox.com \
--cc=johannes@erdfelt.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).