[PATCH PKT_SCHED 0/22]: tc action cleanups

[PATCH PKT_SCHED 0/22]: tc action cleanups

[Patrick McHardy]

Hi Jamal,

following are the reorganized tc action cleanup patches with some
additional fixes. Please review and comment, I would like to ask
Dave to pull them in soon so I don't get more clashes.

bk-tree is at: bk://212.42.230.204/net-2.6-sched

Patrick McHardy:
  o [PKT_SCHED]: Don't export ing_filter
  o [PKT_SCHED]: act_api.c: sync multi action order processing
  o [PKT_SCHED]: act_api.c: push memory allocation to tcf_action_get_1
  o [PKT_SCHED]: act_api.c: remove module loading from get/delete operations
  o [PKT_SCHED]: ipt action: fix module refcnt underflow/mem leaks in 
tcf_ipt_cleanup
  o [PKT_SCHED]: tc actions: remove unnecessary locking for refcnt changes
  o [PKT_SCHED]: ipt action: fix missing unlock on error path
  o [PKT_SCHED]: police action: fix multiple bugs in init path
  o [PKT_SCHED]: pedit action: fix multiple bugs in init path
  o [PKT_SCHED]: mirred action: fix multiple bugs in init path
  o [PKT_SCHED]: ipt action: fix multiple bugs in init path
  o [PKT_SCHED]: gact action: fix multiple bugs in init path
  o [PKT_SCHED]: tc actions: remove checks for impossible conditions
  o [PKT_SCHED]: tc actions: whitespace and coding style cleanup
  o [PKT_SCHED]: act_api.c: clean up init path, propagate errors properly
  o [RTNETLINK]: Use rtattr_strcmp where appropriate
  o [RTNETLINK]: Add rtattr_strlcpy, use it where appropriate
  o [PKT_SCHED]: act_api.c: remove unnecessary initializations
  o [PKT_SCHED]: act_api.c: remove checks for impossible conditions
  o [PKT_SCHED]: act_api.c: use consistent comparision style
  o [PKT_SCHED]: act_api.c: whitespace and coding style cleanup

Rusty Russell:
  o [PKT_SCHED]: Restore net/sched/ipt.c After iptables Kmod Cleanup

Re: [PATCH PKT_SCHED 0/22]: tc action cleanups

[jamal]

On Mon, 2005-01-10 at 14:37, Patrick McHardy wrote:
> Hi Jamal,
> 
> following are the reorganized tc action cleanup patches with some
> additional fixes. Please review and comment, I would like to ask
> Dave to pull them in soon so I don't get more clashes.
> 

Other than the ipt breakage fix - Is there anything new since our last
discussion that you want me to pay attention to? 
Sorry dont have the cycles to pay close attention today. Will do
tommorow. 
You seem to also have touched some police code this time (I suppose the
LinuxWay payoff time is here).So, if you want me to pay close attention
to specific items i will; otherwise i would suggest that Dave sucks them
in, then we can resolve things later.

cheers,
jamal

Re: [PATCH PKT_SCHED 0/22]: tc action cleanups

[Patrick McHardy]

jamal wrote:

>On Mon, 2005-01-10 at 14:37, Patrick McHardy wrote:
>
>>Hi Jamal,
>>
>>following are the reorganized tc action cleanup patches with some
>>additional fixes. Please review and comment, I would like to ask
>>Dave to pull them in soon so I don't get more clashes.
>>
>>
>
>Other than the ipt breakage fix - Is there anything new since our last
>discussion that you want me to pay attention to? 
>Sorry dont have the cycles to pay close attention today. Will do
>tommorow. 
>

There are a couple of new things, more noteable more action init fixes,
but nothing that needs special attention.

>You seem to also have touched some police code this time (I suppose the
>LinuxWay payoff time is here).So, if you want me to pay close attention
>to specific items i will; otherwise i would suggest that Dave sucks them
>in, then we can resolve things later.
>
The police fixes are basically the same as for the other actions.
Some more review can't hurt, but I think we can put them in now.

Dave, please pull in the changes from bk://212.42.230.204/net-2.6-sched

Regards
Patrick

Re: [PATCH PKT_SCHED 0/22]: tc action cleanups

[David S. Miller]

On Mon, 10 Jan 2005 20:37:30 +0100
Patrick McHardy <kaber@trash.net> wrote:

> following are the reorganized tc action cleanup patches with some
> additional fixes. Please review and comment, I would like to ask
> Dave to pull them in soon so I don't get more clashes.

Lots of activity in this area :-)  I'll try to put Thomas's tcf_exts
patches in, then Patrick's on top.  I'll do merge conflict resolution
as necessary but if it gets too hairy we'll need to work on redoing
these patches.

Re: [PATCH PKT_SCHED 0/22]: tc action cleanups

[jamal]

On Mon, 2005-01-10 at 16:21, Patrick McHardy wrote:

> Some more review can't hurt, but I think we can put them in now.

Patrick - just ran my basic tests and all looks good.
I will just stare at the code for a little while and send any comments.
Noticed everything merged in bk3 already.

cheers,
jamal