From: Jeff Garzik <jgarzik@pobox.com>
To: David Hollis <dhollis@davehollis.com>
Cc: Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] tg3.h & b44.h ifndef ADVERTISE_PAUSE typo
Date: Tue, 11 Jan 2005 13:57:44 -0500 [thread overview]
Message-ID: <41E421A8.60203@pobox.com> (raw)
In-Reply-To: <1105454553.4264.4.camel@dhollis-lnx.centricconsulting.com>
David Hollis wrote:
> tg3.h and b44.h define ADVERTISE_PAUSE_CAP if ADVERTISE_PAUSE
> is not defined. Both include a notation that these values should
> be added to mii.h. If ADVERTISE_PAUSE_CAP was added to mii.h,
> these defines would break since they are checking for ADVERTISE_PAUSE
> instead of ADVERTISE_PAUSE_CAP.
>
> Signed-off-by: David Hollis <dhollis@davehollis.com>
>
> drivers/net/b44.h | 2 +-
> drivers/net/tg3.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/net/b44.h 2005-01-11 09:34:39.178739728 -0500
> +++ b/drivers/net/b44.h 2005-01-11 09:34:54.215453800 -0500
> @@ -303,7 +303,7 @@
> #define MII_TLEDCTRL_ENABLE 0x0040
>
> /* XXX Add this to mii.h */
> -#ifndef ADVERTISE_PAUSE
> +#ifndef ADVERTISE_PAUSE_CAP
> #define ADVERTISE_PAUSE_CAP 0x0400
> #endif
> #ifndef ADVERTISE_PAUSE_ASYM
> --- a/drivers/net/tg3.h 2005-01-11 09:34:43.562073360 -0500
> +++ b/drivers/net/tg3.h 2005-01-11 09:35:00.786454856 -0500
> @@ -1532,7 +1532,7 @@
> #define MII_TG3_INT_ANEG_PAGE_RX 0x0400
>
> /* XXX Add this to mii.h */
> -#ifndef ADVERTISE_PAUSE
> +#ifndef ADVERTISE_PAUSE_CAP
> #define ADVERTISE_PAUSE_CAP 0x0400
> #endif
> #ifndef ADVERTISE_PAUSE_ASYM
Just kill the ifdef and add it to mii.h.
Jeff
next prev parent reply other threads:[~2005-01-11 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-11 14:42 [PATCH] tg3.h & b44.h ifndef ADVERTISE_PAUSE typo David Hollis
2005-01-11 18:57 ` Jeff Garzik [this message]
2005-01-11 19:48 ` David Hollis
2005-01-11 20:07 ` Jeff Garzik
2005-01-27 22:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E421A8.60203@pobox.com \
--to=jgarzik@pobox.com \
--cc=dhollis@davehollis.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).