From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Maillist netdev <netdev@oss.sgi.com>
Subject: [PATCH PKT_SCHED 3/6]: tc actions: disable bhs while lock is held in init path
Date: Tue, 11 Jan 2005 22:46:24 +0100 [thread overview]
Message-ID: <41E44930.5040106@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
The lock is also used in softirq context.
[-- Attachment #2: 03.diff --]
[-- Type: text/x-patch, Size: 1714 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2005/01/11 20:32:35+01:00 kaber@coreworks.de
# [PKT_SCHED]: tc actions: disable bhs while lock is held in init path
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/police.c
# 2005/01/11 20:32:28+01:00 kaber@coreworks.de +2 -2
# [PKT_SCHED]: tc actions: disable bhs while lock is held in init path
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/mirred.c
# 2005/01/11 20:32:28+01:00 kaber@coreworks.de +2 -2
# [PKT_SCHED]: tc actions: disable bhs while lock is held in init path
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/sched/mirred.c b/net/sched/mirred.c
--- a/net/sched/mirred.c 2005-01-11 22:32:15 +01:00
+++ b/net/sched/mirred.c 2005-01-11 22:32:15 +01:00
@@ -126,7 +126,7 @@
}
}
- spin_lock(&p->lock);
+ spin_lock_bh(&p->lock);
p->action = parm->action;
p->eaction = parm->eaction;
if (parm->ifindex) {
@@ -137,7 +137,7 @@
dev_hold(dev);
p->ok_push = ok_push;
}
- spin_unlock(&p->lock);
+ spin_unlock_bh(&p->lock);
if (ret == ACT_P_CREATED)
tcf_hash_insert(p);
diff -Nru a/net/sched/police.c b/net/sched/police.c
--- a/net/sched/police.c 2005-01-11 22:32:15 +01:00
+++ b/net/sched/police.c 2005-01-11 22:32:15 +01:00
@@ -224,7 +224,7 @@
}
}
/* No failure allowed after this point */
- spin_lock(&p->lock);
+ spin_lock_bh(&p->lock);
if (R_tab != NULL) {
qdisc_put_rtab(p->R_tab);
p->R_tab = R_tab;
@@ -254,7 +254,7 @@
gen_replace_estimator(&p->bstats, &p->rate_est, p->stats_lock, est);
#endif
- spin_unlock(&p->lock);
+ spin_unlock_bh(&p->lock);
if (ret != ACT_P_CREATED)
return ret;
reply other threads:[~2005-01-11 21:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E44930.5040106@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).