* patch: tc action cleanups
@ 2005-01-16 18:20 jamal
2005-01-16 18:29 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: jamal @ 2005-01-16 18:20 UTC (permalink / raw)
To: Patrick McHardy; +Cc: David S. Miller, netdev
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
Heres one i think you didnt resurect Patrick. If ok, Dave please apply.
Other than that i cant seem to find anything at issue with the core
(havent looked at the individual actions other than to follow changed
code from the core).
Very well done.
cheers,
jamal
[-- Attachment #2: bl_p --]
[-- Type: text/plain, Size: 336 bytes --]
--- a/include/net/pkt_act.h 2005/01/16 13:13:47 1.1
+++ b/include/net/pkt_act.h 2005/01/16 13:15:12
@@ -223,8 +223,10 @@
struct tcf_st *p = NULL;
if (index && (p = tcf_hash_lookup(index)) != NULL) {
if (bind) {
+ spin_lock_bh(&p->lock);
p->bindcnt++;
p->refcnt++;
+ spin_unlock_bh(&p->lock);
}
a->priv = p;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: patch: tc action cleanups
2005-01-16 18:20 patch: tc action cleanups jamal
@ 2005-01-16 18:29 ` Patrick McHardy
2005-01-16 18:41 ` jamal
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2005-01-16 18:29 UTC (permalink / raw)
To: hadi; +Cc: David S. Miller, netdev
jamal wrote:
>Heres one i think you didnt resurect Patrick. If ok, Dave please apply.
>Other than that i cant seem to find anything at issue with the core
>(havent looked at the individual actions other than to follow changed
>code from the core).
>
bindcnt/refcnt changes are protected by the rtnl, no need for extra locking.
The lock only needs to protect data shared with the "act" function.
>Very well done.
>
A couple additional fixes are coming up later tonight.
Regards
Patrick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: patch: tc action cleanups
2005-01-16 18:29 ` Patrick McHardy
@ 2005-01-16 18:41 ` jamal
0 siblings, 0 replies; 3+ messages in thread
From: jamal @ 2005-01-16 18:41 UTC (permalink / raw)
To: Patrick McHardy; +Cc: David S. Miller, netdev
On Sun, 2005-01-16 at 13:29, Patrick McHardy wrote:
> jamal wrote:
>
> >Heres one i think you didnt resurect Patrick. If ok, Dave please apply.
> >Other than that i cant seem to find anything at issue with the core
> >(havent looked at the individual actions other than to follow changed
> >code from the core).
> >
> bindcnt/refcnt changes are protected by the rtnl, no need for extra locking.
> The lock only needs to protect data shared with the "act" function.
Very clever ;-> maybe add a comment then to that effect in your next
batch? Dave ignore that patch.
cheers,
jamal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-01-16 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-16 18:20 patch: tc action cleanups jamal
2005-01-16 18:29 ` Patrick McHardy
2005-01-16 18:41 ` jamal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).