From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Thomas Graf <tgraf@suug.ch>,
"David S. Miller" <davem@davemloft.net>,
netdev@oss.sgi.com
Subject: Re: path: module replay
Date: Sun, 16 Jan 2005 20:50:08 +0100 [thread overview]
Message-ID: <41EAC570.1010003@trash.net> (raw)
In-Reply-To: <41EAC3EE.1020801@trash.net>
Patrick McHardy wrote:
> jamal wrote:
>
>> Ok, here is the last patch. I think module replay should be done from
>> that spot and to be consistent as well from cls_api.c for legacy stuff.
>> I also fixed a module ref count leak. the act_api piece is dependent
>> on what i sent earlier for namsiz.
>> the cls_api change i believe conflicts with what Thomas sent yesterday.
>>
> We have to replay all orders since we dropped the rtnl. An action
> could have done __dev_get_by_* or something similar. Can you send
> a single patch for the module refcount leak please ?
I was wrong, the already initialized actions need to hold their own
references anyway. I'm going have another look and add your patch later
if I don't see other problems.
Regards
Patrick
next prev parent reply other threads:[~2005-01-16 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-16 18:35 patch: namsiz Jamal Hadi Salim
2005-01-16 18:49 ` Patrick McHardy
2005-01-16 18:56 ` Thomas Graf
2005-01-16 19:17 ` Jamal Hadi Salim
2005-01-16 19:32 ` path: module replay jamal
2005-01-16 19:43 ` Patrick McHardy
2005-01-16 19:50 ` Patrick McHardy [this message]
2005-01-19 4:26 ` Patrick McHardy
2005-01-19 13:35 ` jamal
2005-01-19 14:02 ` Patrick McHardy
2005-01-24 13:28 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41EAC570.1010003@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).