From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Maillist netdev <netdev@oss.sgi.com>
Subject: Re: More tc action mess
Date: Wed, 19 Jan 2005 21:22:51 +0100 [thread overview]
Message-ID: <41EEC19B.3010504@trash.net> (raw)
In-Reply-To: <1106140256.1049.903.camel@jzny.localdomain>
jamal wrote:
>On Wed, 2005-01-19 at 00:09, Patrick McHardy wrote:
>
>
>>This means we must convert all paths on which tcf_action_exec is called
>>to use struct sk_buff ** :(
>>
>>
>
>
>No, just restore the code that you took out in one of your patches
>right above that line which reads:
>
>----
> if (skb_cloned(skb)) {
> if (pskb_expand_head(skb, 0, 0, GFP_ATOMIC)) {
> return -1;
> }
> }
>----
>
>Depending on what you do in netfilter lately, you may wanna take out
>the skb_cloned() call.
>
>
This does not help. Netfilter calls skb_ip_make_writable if it has to
touch the packet, if it is shared or cloned the packet will be copied.
Despite this, this is hardly a fix as long as the ->act function takes
a struct sk_buff **.
Regards
Patrick
next prev parent reply other threads:[~2005-01-19 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 5:09 More tc action mess Patrick McHardy
2005-01-19 13:10 ` jamal
2005-01-19 20:22 ` Patrick McHardy [this message]
2005-01-20 4:30 ` jamal
2005-01-20 6:32 ` Patrick McHardy
2005-01-20 13:44 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41EEC19B.3010504@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).