[PATCH] arlan: remove gcc warning with CONFIG_PROC_FS=n

[PATCH] arlan: remove gcc warning with CONFIG_PROC_FS=n

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]


arlan: Fix gcc warning.

With CONFIG_PROC_FS=n, gcc complains:
drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
  drivers/net/wireless/arlan.h |    2 +-
  1 files changed, 1 insertion(+), 1 deletion(-)

[-- Attachment #2: arlan_procfs.patch --]
[-- Type: text/x-patch, Size: 754 bytes --]


arlan: Fix gcc warning.

With CONFIG_PROC_FS=n, gcc complains:
drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
 drivers/net/wireless/arlan.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Naurp ./drivers/net/wireless/arlan.h~arlan_procfs ./drivers/net/wireless/arlan.h
--- ./drivers/net/wireless/arlan.h~arlan_procfs	2005-01-24 13:00:20.000000000 -0800
+++ ./drivers/net/wireless/arlan.h	2005-01-25 21:09:01.963641016 -0800
@@ -43,7 +43,7 @@
 extern int init_arlan_proc(void);
 extern void cleanup_arlan_proc(void);
 #else
-#define init_arlan_proc()	(0)
+#define init_arlan_proc()	({ 0; })
 #define cleanup_arlan_proc()	do { } while (0);
 #endif
 

[PATCH] (v2) arlan: remove gcc warning with CONFIG_PROC_FS=n

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

Here's an update (as pointed out off-list).
Please replace the first one if that works for you.


arlan: Fix gcc warning.

With CONFIG_PROC_FS=n, gcc complains:
drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect

Also remove a useless semi-colon on a #define.

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
  drivers/net/wireless/arlan.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

[-- Attachment #2: arlan_procfs2.patch --]
[-- Type: text/x-patch, Size: 567 bytes --]


diff -Naurp ./drivers/net/wireless/arlan.h~arlan_procfs ./drivers/net/wireless/arlan.h
--- ./drivers/net/wireless/arlan.h~arlan_procfs	2005-01-24 13:00:20.000000000 -0800
+++ ./drivers/net/wireless/arlan.h	2005-01-26 13:58:02.797111176 -0800
@@ -43,8 +43,8 @@
 extern int init_arlan_proc(void);
 extern void cleanup_arlan_proc(void);
 #else
-#define init_arlan_proc()	(0)
-#define cleanup_arlan_proc()	do { } while (0);
+#define init_arlan_proc()	({ 0; })
+#define cleanup_arlan_proc()	do { } while (0)
 #endif
 
 extern struct net_device *arlan_device[MAX_ARLANS];

Re: [PATCH] (v2) arlan: remove gcc warning with CONFIG_PROC_FS=n

[Jean Tourrilhes]

On Wed, Jan 26, 2005 at 05:38:13PM -0800, Randy.Dunlap wrote:
> Here's an update (as pointed out off-list).
> Please replace the first one if that works for you.
> 
> 
> arlan: Fix gcc warning.
> 
> With CONFIG_PROC_FS=n, gcc complains:
> drivers/net/wireless/arlan-main.c:1858: warning: statement with no effect
> 
> Also remove a useless semi-colon on a #define.
> 
> Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
> 
> diffstat:=
>  drivers/net/wireless/arlan.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

	I've never touched that driver, but it looks ok to me. I hope
Jeff will pick it up.

	Jean