netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nivedita Singhvi <niv@us.ibm.com>
To: Andi Kleen <ak@muc.de>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: design for TSO performance fix
Date: Thu, 27 Jan 2005 22:44:43 -0800	[thread overview]
Message-ID: <41F9DF5B.6050305@us.ibm.com> (raw)
In-Reply-To: <m1zmyu2hot.fsf@muc.de>

Andi Kleen wrote:

> I looked at this some time ago to pass lists of packets
> to qdisc and hard_queue_xmit, because that would allow less locking
> overhead and allow some drivers to send stuff more efficiently
> to the hardware registers
> (It was one of the items in my "how to speed up the stack" list ;-) 
> 
> I never ended up implementing it because TSO gave most of the advantages
> anyways.

I admit that it's been several months since I last looked
at this - and was just handwaving, had no code. But I had
thought the converse then - that it might be better
to abandon TSO and just have the stack pass down the list
of skbs in one pass. Had been mentioned by Andi as well as
Anton. We'd get much of the gain, avoid a lot of the
complexity, and the code would be simpler. And I'm not
positive about this but it seemed it would handle memory
fragmentation better, too.

Bogus?

thanks,
Nivedita

  reply	other threads:[~2005-01-28  6:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-28  0:31 design for TSO performance fix David S. Miller
2005-01-28  0:51 ` Rick Jones
2005-01-28  0:58   ` David S. Miller
2005-01-28  1:31 ` Herbert Xu
2005-01-28  5:19   ` David S. Miller
2005-01-28  5:44     ` Herbert Xu
2005-01-28 19:28       ` David S. Miller
2005-01-29 10:12         ` Herbert Xu
2005-01-28  1:57 ` Thomas Graf
2005-02-01 23:04   ` David S. Miller
2005-01-28  6:25 ` Andi Kleen
2005-01-28  6:44   ` Nivedita Singhvi [this message]
2005-01-28 19:30   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41F9DF5B.6050305@us.ibm.com \
    --to=niv@us.ibm.com \
    --cc=ak@muc.de \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).