netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <martin.wilck@fujitsu-siemens.com>
To: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: SIOCGIFMAP silently broken?
Date: Mon, 31 Jan 2005 15:57:09 +0100	[thread overview]
Message-ID: <41FE4745.4020003@fujitsu-siemens.com> (raw)

Hi,

we are using a server management software that uses the irq information
returned by the SIOCGIFMAP ioctl to correlate network interfaces with
LAN hardware.

The code for SIOCGIFMAP if net/core/dev.c simply returns netdev->irq 
which isn't set by most actual LAN drivers any more, and it seems to
be common opinion that setting netdev->irq is either optional or even 
wrong (http://www.ussg.iu.edu/hypermail/linux/kernel/0407.3/1292.html).

Consequently, the SIOCGIFMAP ioctl reports bogus IRQ values for most 
hardware; it is therefore unreliable.

Would it be possible to fix the ioctl such that it returns the correct 
irq value, e.g. be using the irq field of the associated struct pci_dev?

If not, I'd consider it better to deprecate netdev->irq officially and 
always return bogus so that people stop using it.

In both cases, the netdev->irq field isn't used anymore; perhaps it 
should be officially deprecated and/or removed?

Regards
Martin

-- 
Martin Wilck                Phone: +49 5251 8 15113
Fujitsu Siemens Computers   Fax:   +49 5251 8 20409
Heinz-Nixdorf-Ring 1        mailto:Martin.Wilck@Fujitsu-Siemens.com
D-33106 Paderborn           http://www.fujitsu-siemens.com/primergy

             reply	other threads:[~2005-01-31 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-31 14:57 Martin Wilck [this message]
2005-01-31 19:46 ` SIOCGIFMAP silently broken? David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41FE4745.4020003@fujitsu-siemens.com \
    --to=martin.wilck@fujitsu-siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).