Re: [Intel-wired-lan] [PATCH iwl-next v1 10/13] igc: field get conversion

["naamax.meir" <naamax.meir@linux.intel.com>]

On 11/21/2023 23:19, Jesse Brandeburg wrote:
> Refactor the igc driver to use FIELD_GET() for mask and shift reads,
> which reduces lines of code and adds clarity of intent.
> 
> This code was generated by the following coccinelle/spatch script and
> then manually repaired in a later patch.
> 
> @get@
> constant shift,mask;
> expression a;
> @@
> -((a & mask) >> shift)
> +FIELD_GET(mask, a)
> 
> and applied via:
> spatch --sp-file field_prep.cocci --in-place --dir \
>   drivers/net/ethernet/intel/
> 
> Cc: Julia Lawall <Julia.Lawall@inria.fr>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_base.c | 6 ++----
>   drivers/net/ethernet/intel/igc/igc_i225.c | 5 ++---
>   drivers/net/ethernet/intel/igc/igc_main.c | 6 ++----
>   drivers/net/ethernet/intel/igc/igc_phy.c  | 4 ++--
>   4 files changed, 8 insertions(+), 13 deletions(-)

Tested-by: Naama Meir <naamax.meir@linux.intel.com>