netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: "lizhijian@fujitsu.com" <lizhijian@fujitsu.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"shuah@kernel.org" <shuah@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jie2x Zhou <jie2x.zhou@intel.com>,
	"Li Zhijian(intel)" <zhijianx.li@intel.com>
Subject: Re: [PATCH v2] selftests: net: Correct case name
Date: Tue, 7 Dec 2021 20:14:36 -0700	[thread overview]
Message-ID: <41a78a37-6136-ba45-d8fa-c7af4ee772b9@gmail.com> (raw)
In-Reply-To: <bbb91e78-018f-c09c-47db-119010c810c2@fujitsu.com>

On 12/6/21 11:05 PM, lizhijian@fujitsu.com wrote:
>> # TESTS=bind6 ./fcnal-test.sh
>>
>> ###########################################################################
>> IPv6 address binds
>> ###########################################################################
>>
>>
>> #################################################################
>> No VRF
>>
>> TEST: Raw socket bind to local address - ns-A IPv6                            [FAIL]

This one passes for me.

Can you run the test with '-v -p'? -v will give you the command line
that is failing. -p will pause the tests at the failure. From there you
can do:

ip netns exec ns-A bash

Look at the routing - no VRF is involved so the address should be local
to the device and the loopback. Run the test manually to see if it
really is failing.


>> TEST: Raw socket bind to local address after device bind - ns-A IPv6          [ OK ]
>> TEST: Raw socket bind to local address - ns-A loopback IPv6                   [ OK ]
>> TEST: Raw socket bind to local address after device bind - ns-A loopback IPv6  [ OK ]
>> TEST: TCP socket bind to local address - ns-A IPv6                            [ OK ]
>> TEST: TCP socket bind to local address after device bind - ns-A IPv6          [ OK ]
>> TEST: TCP socket bind to out of scope local address - ns-A loopback IPv6      [FAIL]

This one seems to be a new problem. The socket is bound to eth1 and the
address bind is to an address on loopback. That should not be working.

>>
>> #################################################################
>> With VRF
>>
>> TEST: Raw socket bind to local address after vrf bind - ns-A IPv6             [ OK ]
>> TEST: Raw socket bind to local address after device bind - ns-A IPv6          [ OK ]
>> TEST: Raw socket bind to local address after vrf bind - VRF IPv6              [ OK ]
>> TEST: Raw socket bind to local address after device bind - VRF IPv6           [ OK ]
>> TEST: Raw socket bind to invalid local address after vrf bind - ns-A loopback IPv6  [ OK ]
>> TEST: TCP socket bind to local address with VRF bind - ns-A IPv6              [ OK ]
>> TEST: TCP socket bind to local address with VRF bind - VRF IPv6               [ OK ]
>> TEST: TCP socket bind to local address with device bind - ns-A IPv6           [ OK ]
>> TEST: TCP socket bind to VRF address with device bind - VRF IPv6              [FAIL]

This failure is similar to the last one. Need to see if a recent commit
changed something.


>> TEST: TCP socket bind to invalid local address for VRF - ns-A loopback IPv6   [ OK ]
>> TEST: TCP socket bind to invalid local address for device bind - ns-A loopback IPv6  [ OK ]
> 
> 
> Thanks
> Zhijian
> 
> 

  parent reply	other threads:[~2021-12-08  3:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  2:28 [PATCH v2] selftests: net: Correct case name Li Zhijian
2021-12-02 12:20 ` patchwork-bot+netdevbpf
2021-12-07  6:05 ` lizhijian
2021-12-08  3:01   ` David Ahern
2021-12-08  3:28     ` lizhijian
2021-12-08  3:14   ` David Ahern [this message]
2021-12-08  3:38     ` lizhijian
2021-12-08  4:07       ` David Ahern
2021-12-13  3:08         ` Zhou, Jie2X
2021-12-13  4:09           ` David Ahern
2021-12-13  9:44             ` Zhou, Jie2X
2021-12-13 15:58               ` David Ahern
2021-12-15  1:36                 ` Zhou, Jie2X

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41a78a37-6136-ba45-d8fa-c7af4ee772b9@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jie2x.zhou@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lizhijian@fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=zhijianx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).