From: Chris Leech <chris.leech@gmail.com>
To: Raghavendra Koushik <raghavendra.koushik@s2io.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
ravinandan.arakali@s2io.com,
Francois Romieu <romieu@fr.zoreil.com>,
netdev@oss.sgi.com, leonid.grossman@s2io.com,
rapuru.sriram@s2io.com
Subject: Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode
Date: Thu, 14 Oct 2004 13:49:02 -0700 [thread overview]
Message-ID: <41b516cb04101413492af4db1d@mail.gmail.com> (raw)
In-Reply-To: <200410141833.i9EIXI39018452@guinness.s2io.com>
On Thu, 14 Oct 2004 11:33:13 -0700, Raghavendra Koushik
<raghavendra.koushik@s2io.com> wrote:
> > 1) can this not be done with SKB fragments?
> >
> To acheve what is required, the H/W still has to split the Rx'ed frame into
> 2 parts. By implementing this through the SKB fragments method, the only
> thing we avoid is usage of ba_0 and ba_1 fields, but note that none of these
> are allocated or freed in fast path. They are all pre-allocated buffers
> (along with the Rx descriptors) and hence won't hit the Rx side performance.
> Also by pulling down the eth_type_trans implementation partially into the
> driver any kind of copy during Rx is also avoided.
This change would pass skbs from the driver without the MAC header?
What happens in a bridging configuration? And dev->hard_header_parse
is set to eth_header_parse, which expects skb->mac.ethernet to be
valid, so I think any use of packet sockets will result in a NULL
dereference.
- Chris
next prev parent reply other threads:[~2004-10-14 20:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 1:18 [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode Ravinandan Arakali
2004-10-14 15:03 ` Jeff Garzik
2004-10-14 18:33 ` Raghavendra Koushik
2004-10-14 20:49 ` Chris Leech [this message]
2004-10-15 0:02 ` Raghavendra Koushik
2004-10-15 0:21 ` Leonid Grossman
2004-10-15 18:47 ` Jeff Garzik
2004-10-15 19:48 ` Leonid Grossman
2004-10-15 19:57 ` Andi Kleen
2004-10-15 23:14 ` Raghavendra Koushik
2004-10-15 23:15 ` Jeff Garzik
2004-10-14 15:05 ` s2io: patch disposition Jeff Garzik
2004-10-18 22:06 ` Ravinandan Arakali
2004-10-18 22:04 ` Jeff Garzik
2004-10-18 22:21 ` Francois Romieu
2004-10-18 22:38 ` Ravinandan Arakali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41b516cb04101413492af4db1d@mail.gmail.com \
--to=chris.leech@gmail.com \
--cc=jgarzik@pobox.com \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=rapuru.sriram@s2io.com \
--cc=ravinandan.arakali@s2io.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).