From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Chris Leech" <chris.leech@gmail.com>
Subject: Re: Discourage duplicate symbols in the kernel? [Was: Intel I/O Acc...]
Date: Mon, 6 Mar 2006 11:56:28 -0800
Message-ID: <41b516cb0603061156n79d1d572n5f376819ad5f3bf4@mail.gmail.com>
References: <20060303214036.11908.10499.stgit@gitlost.site>
	 <4408C2CA.5010909@garzik.org>
	 <41b516cb0603031439n13e4df4cg8e5b21b606d2b4b8@mail.gmail.com>
	 <20060305000933.2d799138.akpm@osdl.org>
	 <20060305090251.GA9116@mars.ravnborg.org>
	 <20060305011852.368c016e.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Cc: "Sam Ravnborg" <sam@ravnborg.org>, jeff@garzik.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1751571AbWCFT4a@vger.kernel.org>
To: "Andrew Morton" <akpm@osdl.org>
In-Reply-To: <20060305011852.368c016e.akpm@osdl.org>
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On 3/5/06, Andrew Morton <akpm@osdl.org> wrote:
> Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > On Sun, Mar 05, 2006 at 12:09:33AM -0800, Andrew Morton wrote:
> >  > > +
> >  > > +static inline u8 read_reg8(struct cb_device *device, unsigned int offset)
> >  > > +{
> >  > > +        return readb(device->reg_base + offset);
> >  > > +}
> >  >
> >  > These are fairly generic-sounding names.  In fact the as-yet-unmerged tiacx
> >  > wireless driver is already using these, privately to
> >  > drivers/net/wireless/tiacx/pci.c.
> >
> >  Do we in general discourage duplicate symbols even if they are static?
>
> Well, it's a bit irritating that it confuses ctags.  But in this case, one
> set is in a header file so the risk of collisions is much-increased.

They're in a header file that's specific to a single driver, so I
don't see where a conflict would occur.  But I didn't think about
ctags, and these can easily be prefixed so I'll go ahead and change
them.

- Chris