From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH RFC v2 net-next 19/21] net/ipv6: separate handling of FIB
 entries from dst based routes
Date: Sun, 25 Mar 2018 08:49:22 -0600
Message-ID: <41c26fb3-1082-9105-a5e5-95fd11617160@gmail.com>
References: <20180319033622.16693-1-dsahern@gmail.com>
 <20180319033622.16693-20-dsahern@gmail.com> <20180324143100.GA19895@splinter>
 <b5912ae8-0495-3df9-177d-ddd83d5248aa@gmail.com>
 <20180324160209.GB15120@splinter>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        roopa@cumulusnetworks.com, eric.dumazet@gmail.com,
        weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org
To: Ido Schimmel <idosch@idosch.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f48.google.com ([74.125.83.48]:33468 "EHLO
        mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753286AbeCYOte (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 25 Mar 2018 10:49:34 -0400
Received: by mail-pg0-f48.google.com with SMTP id i194so2123384pgd.0
        for <netdev@vger.kernel.org>; Sun, 25 Mar 2018 07:49:33 -0700 (PDT)
In-Reply-To: <20180324160209.GB15120@splinter>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 3/24/18 10:02 AM, Ido Schimmel wrote:
>>
>> ok, I'll take a look. I thought I verified both paths (fib6_info and
>> dst) were freeing the metrics.
> 
> I get this from kmemleak (applied your patchset on top of fe2d55d295cf):
> 
> unreferenced object 0xffff88004e2c16c8 (size 96):
> comm "systemd-network", pid 1255, jiffies 4295166424 (age 957.858s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> backtrace:
> ip6_route_info_create (/net/ipv6/route.c:2849) 
> ip6_route_add (/net/ipv6/route.c:2975) 
> inet6_rtm_newroute (/net/ipv6/route.c:4357) 
> rtnetlink_rcv_msg (/net/core/rtnetlink.c:4643) 
> netlink_rcv_skb (/net/netlink/af_netlink.c:2445) 
> netlink_unicast (/net/netlink/af_netlink.c:1309 /net/netlink/af_netlink.c:1334) 
> netlink_sendmsg (/net/netlink/af_netlink.c:1897) 
> sock_sendmsg (/net/socket.c:630 /net/socket.c:639) 
> SYSC_sendto (/net/socket.c:1748) 
> do_syscall_64 (/arch/x86/entry/common.c:287) 
> entry_SYSCALL_64_after_hwframe (/arch/x86/entry/entry_64.S:239) 
> 0xffffffffffffffff (/./include/asm-generic/sections.h:42) 
> 

Thanks for confirming. I'll take care of it.