From: Claus Hansen Ries <chr@terma.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: [PATCH] net: ll_temac: platform_get_resource replaced by wrong function
Date: Tue, 19 Mar 2024 19:45:26 +0000 [thread overview]
Message-ID: <41c3ea1df1af4f03b2c66728af6812fb@terma.com> (raw)
From: Claus Hansen ries <chr@terma.com>
devm_platform_ioremap_resource_byname is called using 0 as name, which eventually
ends up in platform_get_resource_byname, where it causes a null pointer in strcmp.
if (type == resource_type(r) && !strcmp(r->name, name))
The correct function is devm_platform_ioremap_resource.
Fixes: bd69058 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()")
Signed-off-by: Claus H. Ries <chr@terma.com>
Cc: stable@vger.kernel.org
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 9df39cf8b097..1072e2210aed 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev)
}
/* map device registers */
- lp->regs = devm_platform_ioremap_resource_byname(pdev, 0);
+ lp->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(lp->regs)) {
dev_err(&pdev->dev, "could not map TEMAC registers\n");
return -ENOMEM;
base-commit: d95fcdf4961d27a3d17e5c7728367197adc89b8d
-- 2.39.3 (Apple Git-146)
next reply other threads:[~2024-03-19 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 19:45 Claus Hansen Ries [this message]
2024-03-20 11:54 ` [PATCH] net: ll_temac: platform_get_resource replaced by wrong function Simon Horman
2024-03-20 12:38 ` Claus Hansen Ries
2024-03-20 15:12 ` Dan Carpenter
2024-03-20 16:30 ` Rob Herring
2024-03-20 12:39 ` Shigeru Yoshida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41c3ea1df1af4f03b2c66728af6812fb@terma.com \
--to=chr@terma.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).