From: Jeff Garzik <jgarzik@pobox.com>
To: Dan Williams <dcbw@redhat.com>
Cc: netdev@oss.sgi.com, jgarzik@redhat.com, simon@thekelleys.org.uk
Subject: Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
Date: Tue, 01 Feb 2005 20:33:52 -0500 [thread overview]
Message-ID: <42002E00.6000101@pobox.com> (raw)
In-Reply-To: <1107294126.17332.16.camel@dcbw.boston.redhat.com>
Dan Williams wrote:
> Make the Atmel wireless driver use SET_NETDEV_DEV to get the correct
> entries in sysfs. Seems like somebody meant to do this but it got lost.
> atmel_cs.c was previously fixed to pass in the correct struct device *
> via handle_to_dev() but the driver never actually used it.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
>
> --- a/drivers/net/wireless/atmel.c 2005-01-27 20:26:46.000000000 -0500
> +++ b/drivers/net/wireless/atmel.c 2005-02-01 16:15:55.000000000 -0500
> @@ -1579,6 +1579,8 @@
> dev->irq = irq;
> dev->base_addr = port;
>
> + SET_NETDEV_DEV(dev, sys_dev);
> +
> if ((rc = request_irq(dev->irq, service_interrupt, SA_SHIRQ, dev->name, dev))) {
> printk(KERN_ERR "%s: register interrupt %d failed, rc %d\n", dev->name, irq, rc );
> goto err_out_free;
>
>
Can you please resend all your patches with _just_ the patch inline,
rather than both inline and attached?
Your emails break my scripts, since the scripts try to apply both.
Jeff
next prev parent reply other threads:[~2005-02-02 1:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 21:42 [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV Dan Williams
2005-02-02 1:33 ` Jeff Garzik [this message]
2005-02-02 1:41 ` Dan Williams
2005-02-02 1:52 ` Jeff Garzik
2005-02-02 9:38 ` Christoph Hellwig
2005-02-02 9:59 ` Jeff Garzik
2005-02-02 2:57 ` David Dillow
-- strict thread matches above, loose matches on Subject: below --
2005-02-02 15:16 Dan Williams
2005-02-26 9:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42002E00.6000101@pobox.com \
--to=jgarzik@pobox.com \
--cc=dcbw@redhat.com \
--cc=jgarzik@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=simon@thekelleys.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).