* [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
@ 2005-02-01 21:42 Dan Williams
2005-02-02 1:33 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Dan Williams @ 2005-02-01 21:42 UTC (permalink / raw)
To: netdev; +Cc: jgarzik, simon
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
Make the Atmel wireless driver use SET_NETDEV_DEV to get the correct
entries in sysfs. Seems like somebody meant to do this but it got lost.
atmel_cs.c was previously fixed to pass in the correct struct device *
via handle_to_dev() but the driver never actually used it.
Signed-off-by: Dan Williams <dcbw@redhat.com>
--- a/drivers/net/wireless/atmel.c 2005-01-27 20:26:46.000000000 -0500
+++ b/drivers/net/wireless/atmel.c 2005-02-01 16:15:55.000000000 -0500
@@ -1579,6 +1579,8 @@
dev->irq = irq;
dev->base_addr = port;
+ SET_NETDEV_DEV(dev, sys_dev);
+
if ((rc = request_irq(dev->irq, service_interrupt, SA_SHIRQ, dev->name, dev))) {
printk(KERN_ERR "%s: register interrupt %d failed, rc %d\n", dev->name, irq, rc );
goto err_out_free;
[-- Attachment #2: atmel-NETDEV-fix.patch --]
[-- Type: text/x-patch, Size: 436 bytes --]
--- a/drivers/net/wireless/atmel.c 2005-01-27 20:26:46.000000000 -0500
+++ b/drivers/net/wireless/atmel.c 2005-02-01 16:15:55.000000000 -0500
@@ -1579,6 +1579,8 @@
dev->irq = irq;
dev->base_addr = port;
+ SET_NETDEV_DEV(dev, sys_dev);
+
if ((rc = request_irq(dev->irq, service_interrupt, SA_SHIRQ, dev->name, dev))) {
printk(KERN_ERR "%s: register interrupt %d failed, rc %d\n", dev->name, irq, rc );
goto err_out_free;
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
2005-02-01 21:42 [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV Dan Williams
@ 2005-02-02 1:33 ` Jeff Garzik
2005-02-02 1:41 ` Dan Williams
0 siblings, 1 reply; 9+ messages in thread
From: Jeff Garzik @ 2005-02-02 1:33 UTC (permalink / raw)
To: Dan Williams; +Cc: netdev, jgarzik, simon
Dan Williams wrote:
> Make the Atmel wireless driver use SET_NETDEV_DEV to get the correct
> entries in sysfs. Seems like somebody meant to do this but it got lost.
> atmel_cs.c was previously fixed to pass in the correct struct device *
> via handle_to_dev() but the driver never actually used it.
>
> Signed-off-by: Dan Williams <dcbw@redhat.com>
>
> --- a/drivers/net/wireless/atmel.c 2005-01-27 20:26:46.000000000 -0500
> +++ b/drivers/net/wireless/atmel.c 2005-02-01 16:15:55.000000000 -0500
> @@ -1579,6 +1579,8 @@
> dev->irq = irq;
> dev->base_addr = port;
>
> + SET_NETDEV_DEV(dev, sys_dev);
> +
> if ((rc = request_irq(dev->irq, service_interrupt, SA_SHIRQ, dev->name, dev))) {
> printk(KERN_ERR "%s: register interrupt %d failed, rc %d\n", dev->name, irq, rc );
> goto err_out_free;
>
>
Can you please resend all your patches with _just_ the patch inline,
rather than both inline and attached?
Your emails break my scripts, since the scripts try to apply both.
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
2005-02-02 1:33 ` Jeff Garzik
@ 2005-02-02 1:41 ` Dan Williams
2005-02-02 1:52 ` Jeff Garzik
2005-02-02 2:57 ` David Dillow
0 siblings, 2 replies; 9+ messages in thread
From: Dan Williams @ 2005-02-02 1:41 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, jgarzik, simon
And both evolution and pine screw up the patches inline and break the
line at odd places... at least, that's what I see... you don't mind if
you have to do a little surgery here and there?
Dan
On Tue, 2005-02-01 at 20:33 -0500, Jeff Garzik wrote:
> Dan Williams wrote:
> > Make the Atmel wireless driver use SET_NETDEV_DEV to get the correct
> > entries in sysfs. Seems like somebody meant to do this but it got lost.
> > atmel_cs.c was previously fixed to pass in the correct struct device *
> > via handle_to_dev() but the driver never actually used it.
> >
> > Signed-off-by: Dan Williams <dcbw@redhat.com>
> >
> > --- a/drivers/net/wireless/atmel.c 2005-01-27 20:26:46.000000000 -0500
> > +++ b/drivers/net/wireless/atmel.c 2005-02-01 16:15:55.000000000 -0500
> > @@ -1579,6 +1579,8 @@
> > dev->irq = irq;
> > dev->base_addr = port;
> >
> > + SET_NETDEV_DEV(dev, sys_dev);
> > +
> > if ((rc = request_irq(dev->irq, service_interrupt, SA_SHIRQ, dev->name, dev))) {
> > printk(KERN_ERR "%s: register interrupt %d failed, rc %d\n", dev->name, irq, rc );
> > goto err_out_free;
> >
> >
>
> Can you please resend all your patches with _just_ the patch inline,
> rather than both inline and attached?
>
> Your emails break my scripts, since the scripts try to apply both.
>
> Jeff
>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
2005-02-02 1:41 ` Dan Williams
@ 2005-02-02 1:52 ` Jeff Garzik
2005-02-02 9:38 ` Christoph Hellwig
2005-02-02 2:57 ` David Dillow
1 sibling, 1 reply; 9+ messages in thread
From: Jeff Garzik @ 2005-02-02 1:52 UTC (permalink / raw)
To: Dan Williams; +Cc: netdev, jgarzik, simon
Dan Williams wrote:
> And both evolution and pine screw up the patches inline and break the
> line at odd places... at least, that's what I see... you don't mind if
> you have to do a little surgery here and there?
This is why we have request a common patch format -- because otherwise,
everybody would request just-a-little-surgery-here-and-there.
It's much easier in the long run to get people to find solutions
(pine+vi or mutt or Mozilla Mail) that work, than to hope that a
maintainer will know and fix up each submittor's mailer's eccentricities.
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
2005-02-02 1:52 ` Jeff Garzik
@ 2005-02-02 9:38 ` Christoph Hellwig
2005-02-02 9:59 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2005-02-02 9:38 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Dan Williams, netdev, jgarzik, simon
On Tue, Feb 01, 2005 at 08:52:45PM -0500, Jeff Garzik wrote:
> It's much easier in the long run to get people to find solutions
> (pine+vi or mutt or Mozilla Mail) that work, than to hope that a
> maintainer will know and fix up each submittor's mailer's eccentricities.
Mozilla Mail is fucked up for sending patches aswell.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
2005-02-02 9:38 ` Christoph Hellwig
@ 2005-02-02 9:59 ` Jeff Garzik
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Garzik @ 2005-02-02 9:59 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Dan Williams, netdev, jgarzik, simon
Christoph Hellwig wrote:
> On Tue, Feb 01, 2005 at 08:52:45PM -0500, Jeff Garzik wrote:
>
>>It's much easier in the long run to get people to find solutions
>>(pine+vi or mutt or Mozilla Mail) that work, than to hope that a
>>maintainer will know and fix up each submittor's mailer's eccentricities.
>
>
> Mozilla Mail is fucked up for sending patches aswell.
Works for me.
Jeff
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
2005-02-02 1:41 ` Dan Williams
2005-02-02 1:52 ` Jeff Garzik
@ 2005-02-02 2:57 ` David Dillow
1 sibling, 0 replies; 9+ messages in thread
From: David Dillow @ 2005-02-02 2:57 UTC (permalink / raw)
To: Dan Williams; +Cc: Jeff Garzik, Netdev, jgarzik, simon
On Tue, 2005-02-01 at 20:41 -0500, Dan Williams wrote:
> And both evolution and pine screw up the patches inline and break the
> line at odd places... at least, that's what I see... you don't mind if
> you have to do a little surgery here and there?
Have you tried setting the format to "Preformat", and using
Insert->Insert File... ?
This is a really long line entered in "preformat" mode, and notice it doesn't wrap (if you look at it in text.)
--
David Dillow <dave@thedillows.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV
@ 2005-02-02 15:16 Dan Williams
2005-02-26 9:11 ` Jeff Garzik
0 siblings, 1 reply; 9+ messages in thread
From: Dan Williams @ 2005-02-02 15:16 UTC (permalink / raw)
To: netdev; +Cc: jgarzik, simon
Make the Atmel wireless driver use SET_NETDEV_DEV to get the correct
entries in sysfs. Seems like somebody meant to do this but it got lost.
atmel_cs.c was previously fixed to pass in the correct struct device *
via handle_to_dev() but the driver never actually used it.
Signed-off-by: Dan Williams <dcbw@redhat.com>
--- a/drivers/net/wireless/atmel.c 2005-01-27 20:26:46.000000000 -0500
+++ b/drivers/net/wireless/atmel.c 2005-02-01 16:15:55.000000000 -0500
@@ -1579,6 +1579,8 @@
dev->irq = irq;
dev->base_addr = port;
+ SET_NETDEV_DEV(dev, sys_dev);
+
if ((rc = request_irq(dev->irq, service_interrupt, SA_SHIRQ, dev->name, dev))) {
printk(KERN_ERR "%s: register interrupt %d failed, rc %d\n", dev->name, irq, rc );
goto err_out_free;
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2005-02-26 9:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-01 21:42 [PATCH 2.6.11-rc2] wireless: Make Atmel driver use SET_NETDEV_DEV Dan Williams
2005-02-02 1:33 ` Jeff Garzik
2005-02-02 1:41 ` Dan Williams
2005-02-02 1:52 ` Jeff Garzik
2005-02-02 9:38 ` Christoph Hellwig
2005-02-02 9:59 ` Jeff Garzik
2005-02-02 2:57 ` David Dillow
-- strict thread matches above, loose matches on Subject: below --
2005-02-02 15:16 Dan Williams
2005-02-26 9:11 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).