From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA4262E7635; Mon, 27 Apr 2026 02:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777257350; cv=none; b=CeKtqMOgovKuL2OlLNOw3zSxTxZEwz0zFwSrOqWrhmMGHCXWTrDQtv2zh9WC1k/NUNjzZg6FQDbXek3nCDhqtsQ/QTQgqxIMG3gR4eTupt8IH0zrUIaGwHv9a34yx2BpdvX6UvTEjihfmdCcd+7QJ7GVrWK+V0jq3a2AtJzHFj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777257350; c=relaxed/simple; bh=GKrByMniTwmG3Bjyw+UoCiRn1kmEwA/XQSRNSc5ZDOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gU6STXyjcTVqTnWQkOAsKTJebXDluXtyJKpY2OxPmYguVlQrEND39wdY4yHjIfV1dAbsHuJwUN5Pzs1xB8FouaxdyBbBs5gBZNh/qYQ660pyLXXkud1pjlOZpsLbPlYy2szaBt/mkloScVerU9OLTBSZvLkwS6Nk7JdhnxrPvMc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=UN+3sYGN; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="UN+3sYGN" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=zni08zNYUA9Kcs3QKHXh+0X7eCZUOzQbgnCEbOl9KWQ=; b=UN +3sYGNmo/5vbwknrnID6YODUQjbRsJ4G/n19nQjfN+0MujL0pmbB+s1H3mEw68TFUROdA+t0XArRz lKI7seuHbnpZXS9neexNgCsYrBy+SXBvfD2wxfRSY6ook4xgg50LB8nqm8MPmFJ/iy7E12NNVV/IB 3EoGKs4OEDKO8zM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wHBoz-0005hr-4T; Mon, 27 Apr 2026 04:35:41 +0200 Date: Mon, 27 Apr 2026 04:35:41 +0200 From: Andrew Lunn To: =?utf-8?B?67CV66qF7ZuI?= Cc: Hartley Sweeten , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ijae Kim , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH DRAFT] net: cirrus: ep93xx: fix probe error unwind Message-ID: <4201a9ff-c137-4e08-85f8-32aaa6aa3836@lunn.ch> References: <20260426141010.19049-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260426141010.19049-1-pakmyeonghun@bagmyeonghun-ui-MacBookPro.local> On Sun, Apr 26, 2026 at 11:10:06PM +0900, 박명훈 wrote: > From: Myeonghun Pak > > ep93xx_eth_probe() uses ep93xx_eth_remove() as common error unwind > after setting driver data. When register_netdev() fails, this calls > unregister_netdev() for a net_device that was never registered. The > net core treats that as a driver bug and emits WARN_ON(1). How did you trigger the failure of register_netdev()? Andrew