From: Jeff Garzik <jgarzik@pobox.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: schwidefsky@de.ibm.com, akpm@osdl.org, Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] s390: qeth network driver
Date: Thu, 03 Feb 2005 22:05:55 -0500 [thread overview]
Message-ID: <4202E693.90808@pobox.com> (raw)
In-Reply-To: <200502040211.j142BI35023854@hera.kernel.org>
Linux Kernel Mailing List wrote:
> ChangeSet 1.2072, 2005/02/03 17:04:37-08:00, schwidefsky@de.ibm.com
>
> [PATCH] s390: qeth network driver
>
> From: Steffen Thoss <thoss@de.ibm.com>
> From: Frank Pavlic <pavlic@de.ibm.com>
>
> qeth network driver changes:
> - Improve performance by omitting svs.
> - Use function callback mechanism to set layer 2 parameters when getting
> a reply for a Layer 2 command.
> - dev->hard_header must not be NULL when fake_ll is no set since
> IPv6 and Layer2 needs the default function set by network stack.
> - ping6 works now when running in layer 2 mode.
> - Save original dev->hard_header to restore it when the user doesn't
> want to use fake_ll anymore.
> - Fake ethernet header in outgoing packets. This currently works
> only if qeth is compiled without ipv6 support.
> - Add more debug information in case of failures in qeth_set_offline.
> - Using fake_ll with HiperSockets devices results in misaligned
> ip packets and thus no traffic over HiperSockets.
> - Start qeth_remove_device only after the qeth recovery completed.
>
> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
It would be nice if this stuff was CC'd to the network, and network
driver maintainers.
Two immediate concerns I have are,
* saving and restoring dev->hard_header is more than a little bit of a hack
* overall, I'm not so sure IPv6 support should be conditionalized on
anything but CONFIG_IPV6. Though S/390 and qeth are certainly unusual
cases, none of the other net drivers in the kernel require a special
config option to enable IPv6 support.
Jeff
parent reply other threads:[~2005-02-04 3:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200502040211.j142BI35023854@hera.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4202E693.90808@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).