netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Maillist netdev <netdev@oss.sgi.com>
Subject: [PATCH 2.6.11 PKT_SCHED]: ipt action: add back pskb_expand_head call
Date: Fri, 04 Feb 2005 04:10:54 +0100	[thread overview]
Message-ID: <4202E7BE.6050606@trash.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

Hi Dave,

Jamal asked me to add back the call to pskb_expand_head before 2.6.11.
This fixes a regression caused by my tc action cleanup patches, the
tc actions most not replace packets, so it must prevent netfilter from
doing so.

Regards
Patrick


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 396 bytes --]

===== net/sched/ipt.c 1.13 vs edited =====
--- 1.13/net/sched/ipt.c	2005-01-14 05:41:07 +01:00
+++ edited/net/sched/ipt.c	2005-02-04 04:06:45 +01:00
@@ -207,6 +207,11 @@
 	struct tcf_ipt *p = PRIV(a, ipt);
 	struct sk_buff *skb = *pskb;
 
+	if (skb_cloned(skb)) {
+		if (pskb_expand_head(skb, 0, 0, GFP_ATOMIC))
+			return TC_ACT_UNSPEC;
+	}
+
 	spin_lock(&p->lock);
 
 	p->tm.lastuse = jiffies;

             reply	other threads:[~2005-02-04  3:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-04  3:10 Patrick McHardy [this message]
2005-02-04  4:09 ` [PATCH 2.6.11 PKT_SCHED]: ipt action: add back pskb_expand_head call Patrick McHardy
2005-02-07  6:04 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4202E7BE.6050606@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).