From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3119B1624D5 for ; Sat, 3 Oct 2026 09:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791021326; cv=none; b=JB7/Z7ioZQqCok41/fgib1LBsZk28iXCXNKLc+UNCU3zxZ58PHxbyZYuuippvX2i95eKdFXdix5ptQl0+O5FVSh1NBzi6JxZQBHCf9PeKlR2DsZlGDFE69zTrx9FHW9UOALBcWa+rinA2iGT8JVY3xJ7zvQRIsRXmxBeJOodd7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791021326; c=relaxed/simple; bh=q0PnyaOp7rmWQVGcbuwICe+ZVkM09BC25gMqef48JT4=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=CWwQISHJAck3WRBs9x6Ky4Iytz1RL3hxL1pv7/8tT4X31uHIRvcqFQw5s09HUVG2e0b32cXC7Nc8OuG6NCZPuhG8FWiZijijuWGoSuslrz4674MaDuQ9GiNi4Bv+GxxH5ScXmOX8rspcZU4yMm2WRToUorao4RqU8zmZxiaYiPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CtzuYpK0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IGL3U1t/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CtzuYpK0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IGL3U1t/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791021324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T2/SsgxfyWuM6rZwWMjamjv6eHU2cXgtGdTv8wJ/i0M=; b=CtzuYpK0BFKX7U0p5qXcizYzRsMOxnSAJQ1mIxlA8vSUMB76BrZ/vZurgCGIynq/kxCQ6z wF1z01zWxSCMqZ8nlOu/Fb6+LhTakfHYrSsgunLUhKgEBk5/z0ip4R5pkC7t2NitBz1QoX y2wubDtd5V6AjT2hSYWHzqvUfROtd60= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-xn-BdtR8MvWC_PawhFm0mQ-1; Sat, 03 Oct 2026 05:55:22 -0400 X-MC-Unique: xn-BdtR8MvWC_PawhFm0mQ-1 X-Mimecast-MFC-AGG-ID: xn-BdtR8MvWC_PawhFm0mQ_1791021322 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-495689bfcc8so4003565e9.1 for ; Sat, 03 Oct 2026 02:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1791021321; x=1791626121; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=T2/SsgxfyWuM6rZwWMjamjv6eHU2cXgtGdTv8wJ/i0M=; b=IGL3U1t/at0vVl74+S2jKer7cMaM/xsptwCUUHlfWnJw/ZPejPn3DHzzG2AYWREHrH x957Q6Az5fHyJkUT5xcbQs/l1TtOkh0uJieA6Tb6GxklxJ5EsAoa9ipujjs4lwLXMv9x rVdldrvaoC0slbVyhknBXPl0f0ae2llCES8UdHJkHQqktY+CDSnyQLSjuGobkEneHhoN fJ8eUeFhiUItsxYjsNMYlB28i0b0TZ5D5Lmz1k/exhvkoiPMGzhAumeTWzKTkcTTtb+D msDZZGj7sUwrZSatEtEff6HwizvvczypKujIiCkazAcTgrZtyj9xcbfWHwgfXwlWA2er hJkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791021321; x=1791626121; h=content-transfer-encoding:content-type:mime-version:message-id :references:in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T2/SsgxfyWuM6rZwWMjamjv6eHU2cXgtGdTv8wJ/i0M=; b=ooxNVOVXaiwayUDIi1QN2aZFDJ/VvI5OYFy5yimgXk+y+6s3bSStx4l6MvChKdsnyo zpPDYXH3GBl7lzvFz2imT1Y57miPI7dppccfKVxFuYNCma1O3UjLB9BlTiKhharrSgV+ wmM/t7xl0VfxBzv4Q2zsJuGanyeHQMR+IpuM1J6BzfhcPfmWyaIcNFFl0gu6u3MdvzAi 5PJe+sOAx/QT6yiTL9EkrvIWwMEaVxPWN7kzPNn6OyL8EwPyAvx/IVTHxh3yFrvm8oa6 1Lpk5eJ17l3qD8WLRciavq2KCTGu9/Tvq5idj3OgHA9BbUAmn+Ee8f9zSG4IqYne6OmS /MdA== X-Forwarded-Encrypted: i=1; AKwUvBzFJohVZibfVQcgXgtQkr9tyhnLBPhaRjvUexe42x/VECVyOOXMMiSf2Y6Lrw26Gty0mxoTd4Q=@vger.kernel.org X-Gm-Message-State: AFuF++lt+G9gPGXFG5Kh7bo7JJusxicgY5K4E86dy5aFYBdgDghPF+mR Rr14iXNjq3YDxwS1o0bDWqamfxcnfc0V3QGCjCQu/jtqeCwmS2SJ5cCp9PWlgYwa0XOkz1xFHuk gr3CGzg/gg0epfxVXxnrGW0Jtmcak8zmPHOzHFQbqU2y16sh1d5N0RDdxzA== X-Gm-Gg: AYBFou1U/s6g+8DIdluf/og0qYBAFJficW1qYq4NBk0hcZXVgsnFV0c+1D6ZPDu+uSx npbfqRUHN78MZu83NCz3qTXDPz7sR2jY+akGuwf24F7XM3xC8Vl7R592Qd4V2pbmyYyH0MkBFWc KtPqNEBYu2Ede5Ilsze8bObbBMXAqFjWEfK8o4R6Qe1ZYausojRrv9ddx92rgOtUx3kPTNXDZ9F fnVYzpyv021/oXZibOEgxVYa8rkYKsRIjpQku1jW/zGa71wIiXpOBSJ5pUVAHqZtNScKwTwqf7K md6HPkx1joccNKz4SNtfTLdKEWDg6uCZC4vMLbt8ODcwT6MRmvGfjv5XSAJK5ngE8tOHeA8AwT7 u+sYemYETzkfdot8c9P4wtWlfIXRRdnv5TB/1clI= X-Received: by 2002:a05:600c:858b:b0:4a0:1f9e:5f7d with SMTP id 5b1f17b1804b1-4a0275430a0mr66345355e9.7.1791021321657; Sat, 03 Oct 2026 02:55:21 -0700 (PDT) X-Received: by 2002:a05:600c:858b:b0:4a0:1f9e:5f7d with SMTP id 5b1f17b1804b1-4a0275430a0mr66344995e9.7.1791021321223; Sat, 03 Oct 2026 02:55:21 -0700 (PDT) Received: from ehlo.thunderbird.net ([2a00:e580:bf11:1:2666:d874:79e6:3214]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b38104d58sm12126984f8f.28.2026.10.03.02.55.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Oct 2026 02:55:20 -0700 (PDT) Date: Sat, 03 Oct 2026 11:55:19 +0200 From: Ivan Vecera To: intel-wired-lan@osuosl.org, Petr Oros , netdev@vger.kernel.org CC: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Lobakin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Henry Tieman , Anirudh Venkataramanan , Michal Swiatkowski , Jesse Brandeburg , Preethi Banala , Kiran Patil , Dan Nowlin , Stephen Hemminger , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_iwl-net_05/10=5D_ice=3A_report_VF_tx=5F?= =?US-ASCII?Q?dropped_with_tx=5Ferrors_instead_of_tx=5Fdiscards?= User-Agent: Thunderbird for Android In-Reply-To: <20261002130752.2597259-6-poros@redhat.com> References: <20261002130752.2597259-1-poros@redhat.com> <20261002130752.2597259-6-poros@redhat.com> Message-ID: <42067B5C-78B8-4580-BAC9-7E03520EB167@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 2, 2026 3:07:47 PM GMT+02:00, Petr Oros wro= te: >ice_get_vf_stats() fills tx_dropped from eth_stats=2Etx_discards, which >ice_update_eth_stats() never updates because the GLV_TDPC register it >would come from is not implemented in E810 hardware=2E The Tx drops of a >VF, such as switch drops on an anti spoof violation, malicious driver >drops or TTL expiry, are counted by GLV_TEPC into eth_stats=2Etx_errors >instead, so the VF always reports zero dropped packets=2E > >With spoof checking on, a VF sending 60 valid frames and 30 frames with >a forged source MAC shows: > > vf 0 =2E=2E=2E spoof checking on, link-state auto, trust off > TX: bytes packets dropped > 3600 60 0 > >Report tx_errors as tx_dropped, the VF stats have no separate error >field=2E With the change the same test reports 30 dropped packets=2E > >i40e fixed the same issue in commit 50b2af451597 ("i40e: report VF >tx_dropped with tx_errors instead of tx_discards")=2E > >Fixes: 730fdea40bef ("ice: implement VF stats NDO") >Assisted-by: LLM >Signed-off-by: Petr Oros >--- > drivers/net/ethernet/intel/ice/ice_sriov=2Ec | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/intel/ice/ice_sriov=2Ec b/drivers/net/e= thernet/intel/ice/ice_sriov=2Ec >index b21279f0f5f1e1=2E=2E8faddf8ba0d523 100644 >--- a/drivers/net/ethernet/intel/ice/ice_sriov=2Ec >+++ b/drivers/net/ethernet/intel/ice/ice_sriov=2Ec >@@ -1640,7 +1640,7 @@ int ice_get_vf_stats(struct net_device *netdev, int= vf_id, > vf_stats->broadcast =3D stats->rx_broadcast; > vf_stats->multicast =3D stats->rx_multicast; > vf_stats->rx_dropped =3D stats->rx_discards; >- vf_stats->tx_dropped =3D stats->tx_discards; >+ vf_stats->tx_dropped =3D stats->tx_errors; >=20 > out_put_vf: > ice_put_vf(vf); Reviewed-by: Ivan Vecera