From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
Ong Boon Leong <boon.leong.ong@intel.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups
Date: Wed, 1 Apr 2026 14:19:27 +0200 [thread overview]
Message-ID: <420f910f-523d-4a74-a255-2fe48909283a@lunn.ch> (raw)
In-Reply-To: <aczHVF04LIGq_lYO@shell.armlinux.org.uk>
> I'm moving the setup of the GSO features, cleaning those up, and
> adding a warning if platform glue requests this to be enabled but the
> hardware has no support. Hopefully this will never trigger if everyone
> got the STMMAC_FLAG_TSO_EN flag correct.
Is this:
snps,tso:
$ref: /schemas/types.yaml#/definitions/flag
description:
Enables the TSO feature otherwise it will be managed by MAC HW capability
register.
I would not be too surprised if there is cargo cult copy/paste going
on and some do get it wrong.
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi: snps,tso;
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi: snps,tso;
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi: snps,tso;
arch/arm64/boot/dts/toshiba/tmpv7708.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3588-extra.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3576.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3576.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3568.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3528.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk3528.dtsi: snps,tso;
arch/arm64/boot/dts/rockchip/rk356x-base.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/qcs404.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/lemans.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/lemans.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/sm8150.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/sc8280xp.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/sc8280xp.dtsi: snps,tso;
arch/arm64/boot/dts/qcom/monaco.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp253.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp233.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp231.dtsi: snps,tso;
arch/arm64/boot/dts/st/stm32mp251.dtsi: snps,tso;
arch/riscv/boot/dts/sophgo/sg2042.dtsi: snps,tso;
arch/riscv/boot/dts/sophgo/sg2044.dtsi: snps,tso;
arch/riscv/boot/dts/starfive/jh7110.dtsi: snps,tso;
arch/riscv/boot/dts/starfive/jh7110.dtsi: snps,tso;
arch/arm/boot/dts/axis/artpec6.dtsi: snps,tso;
arch/arm/boot/dts/rockchip/rv1126.dtsi: snps,tso;
arch/arm/boot/dts/st/stm32mp131.dtsi: snps,tso;
arch/arm/boot/dts/st/stm32mp133.dtsi: snps,tso;
arch/arm/boot/dts/st/stm32mp151.dtsi: snps,tso;
Andrew
next prev parent reply other threads:[~2026-04-01 12:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 7:20 [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 01/14] net: stmmac: fix channel TSO enable on resume Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 02/14] net: stmmac: fix .ndo_fix_features() Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 03/14] net: stmmac: fix TSO support when some channels have TBS available Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 04/14] net: stmmac: add stmmac_tso_header_size() Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 05/14] net: stmmac: add TSO check for header length Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 06/14] net: stmmac: add GSO MSS checks Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 07/14] net: stmmac: move TSO VLAN tag insertion to core code Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 08/14] net: stmmac: move check for hardware checksum supported Russell King (Oracle)
2026-04-01 7:21 ` [PATCH net-next v2 09/14] net: stmmac: simplify GSO/TSO test in stmmac_xmit() Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 10/14] net: stmmac: split out gso features setup Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 11/14] net: stmmac: make stmmac_set_gso_features() more readable Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 12/14] net: stmmac: add warning when TSO is requested but unsupported Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 13/14] net: stmmac: check txpbl for TSO Russell King (Oracle)
2026-04-01 7:22 ` [PATCH net-next v2 14/14] net: stmmac: move "TSO supported" message to stmmac_set_gso_features() Russell King (Oracle)
2026-04-01 12:19 ` Andrew Lunn [this message]
2026-04-01 12:41 ` [PATCH net-next v2 00/14] net: stmmac: TSO fixes/cleanups Russell King (Oracle)
2026-04-02 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420f910f-523d-4a74-a255-2fe48909283a@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox