Re: [PATCH v9 23/24] wfx: remove from the staging area

Kalle Valo
2022-01-12T07:50:05Z

Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:

> From: Jérôme Pouiller <jerome.pouiller@silabs.com>
>
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> ---
> .../bindings/net/wireless/silabs,wfx.yaml | 125 ---
> drivers/staging/wfx/Kconfig | 8 -
> drivers/staging/wfx/Makefile | 25 -
> drivers/staging/wfx/bh.c | 330 -------
> drivers/staging/wfx/bh.h | 33 -
> drivers/staging/wfx/bus.h | 38 -
> drivers/staging/wfx/bus_sdio.c | 272 ------
> drivers/staging/wfx/bus_spi.c | 271 ------
> drivers/staging/wfx/data_rx.c | 94 --
> drivers/staging/wfx/data_rx.h | 18 -
> drivers/staging/wfx/data_tx.c | 596 -------------
> drivers/staging/wfx/data_tx.h | 68 --
> drivers/staging/wfx/debug.c | 365 --------
> drivers/staging/wfx/debug.h | 19 -
> drivers/staging/wfx/fwio.c | 405 ---------
> drivers/staging/wfx/fwio.h | 15 -
> drivers/staging/wfx/hif_api_cmd.h | 555 ------------
> drivers/staging/wfx/hif_api_general.h | 262 ------
> drivers/staging/wfx/hif_api_mib.h | 346 --------
> drivers/staging/wfx/hif_rx.c | 416 ---------
> drivers/staging/wfx/hif_rx.h | 17 -
> drivers/staging/wfx/hif_tx.c | 513 -----------
> drivers/staging/wfx/hif_tx.h | 60 --
> drivers/staging/wfx/hif_tx_mib.c | 324 -------
> drivers/staging/wfx/hif_tx_mib.h | 49 --
> drivers/staging/wfx/hwio.c | 352 --------
> drivers/staging/wfx/hwio.h | 75 --
> drivers/staging/wfx/key.c | 241 -----
> drivers/staging/wfx/key.h | 20 -
> drivers/staging/wfx/main.c | 506 -----------
> drivers/staging/wfx/main.h | 43 -
> drivers/staging/wfx/queue.c | 307 -------
> drivers/staging/wfx/queue.h | 45 -
> drivers/staging/wfx/scan.c | 149 ----
> drivers/staging/wfx/scan.h | 22 -
> drivers/staging/wfx/sta.c | 833 ------------------
> drivers/staging/wfx/sta.h | 73 --
> drivers/staging/wfx/traces.h | 501 -----------
> drivers/staging/wfx/wfx.h | 164 ----
> 39 files changed, 8555 deletions(-)
> delete mode 100644 drivers/staging/wfx/Documentation/devicetree/bindings/net/wireless/silabs,wfx.yaml
> delete mode 100644 drivers/staging/wfx/Kconfig
> delete mode 100644 drivers/staging/wfx/Makefile
> delete mode 100644 drivers/staging/wfx/bh.c
> delete mode 100644 drivers/staging/wfx/bh.h
> delete mode 100644 drivers/staging/wfx/bus.h
> delete mode 100644 drivers/staging/wfx/bus_sdio.c
> delete mode 100644 drivers/staging/wfx/bus_spi.c
> delete mode 100644 drivers/staging/wfx/data_rx.c
> delete mode 100644 drivers/staging/wfx/data_rx.h
> delete mode 100644 drivers/staging/wfx/data_tx.c
> delete mode 100644 drivers/staging/wfx/data_tx.h
> delete mode 100644 drivers/staging/wfx/debug.c
> delete mode 100644 drivers/staging/wfx/debug.h
> delete mode 100644 drivers/staging/wfx/fwio.c
> delete mode 100644 drivers/staging/wfx/fwio.h
> delete mode 100644 drivers/staging/wfx/hif_api_cmd.h
> delete mode 100644 drivers/staging/wfx/hif_api_general.h
> delete mode 100644 drivers/staging/wfx/hif_api_mib.h
> delete mode 100644 drivers/staging/wfx/hif_rx.c
> delete mode 100644 drivers/staging/wfx/hif_rx.h
> delete mode 100644 drivers/staging/wfx/hif_tx.c
> delete mode 100644 drivers/staging/wfx/hif_tx.h
> delete mode 100644 drivers/staging/wfx/hif_tx_mib.c
> delete mode 100644 drivers/staging/wfx/hif_tx_mib.h
> delete mode 100644 drivers/staging/wfx/hwio.c
> delete mode 100644 drivers/staging/wfx/hwio.h
> delete mode 100644 drivers/staging/wfx/key.c
> delete mode 100644 drivers/staging/wfx/key.h
> delete mode 100644 drivers/staging/wfx/main.c
> delete mode 100644 drivers/staging/wfx/main.h
> delete mode 100644 drivers/staging/wfx/queue.c
> delete mode 100644 drivers/staging/wfx/queue.h
> delete mode 100644 drivers/staging/wfx/scan.c
> delete mode 100644 drivers/staging/wfx/scan.h
> delete mode 100644 drivers/staging/wfx/sta.c
> delete mode 100644 drivers/staging/wfx/sta.h
> delete mode 100644 drivers/staging/wfx/traces.h
> delete mode 100644 drivers/staging/wfx/wfx.h

I'm not sure what's your plan here, but with staging wireless drivers
there's usually a simple simple move (git mv) of the driver from
drivers/staging to drivers/net/wireless. An example here:

https://git.kernel.org/linus/5625f965d764

What you seem to do here is that you add a new driver to
drivers/net/wireless and then remove the old driver from
drivers/staging. And I'm guessing these two drivers are not identical
and have differences?

--