netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-drivers-2.6 1/10] e1000: Robert Olsson's fix and refinement to the poll routine
@ 2005-02-15 21:24 Malli Chilakala
  2005-02-21  2:14 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Malli Chilakala @ 2005-02-15 21:24 UTC (permalink / raw)
  To: jgarzik@pobox.com; +Cc: netdev

1 Robert Olsson's fix and refinement to the poll routine
Signed-off-by: Mallikarjuna R Chilakala <mallikarjuna.chilakala@intel.com>
Signed-off-by: Ganesh Venkatesan <ganesh.venkatesan@intel.com>
Signed-off-by: John Ronciak <john.ronciak@intel.com>
diff -up net-drivers-2.6/drivers/net/e1000/e1000_main.c net-drivers-2.6/drivers/net/e1000.new/e1000_main.c
--- net-drivers-2.6/drivers/net/e1000/e1000_main.c	2005-02-01 23:10:24.989105880 -0800
+++ net-drivers-2.6/drivers/net/e1000.new/e1000_main.c	2005-02-01 23:10:26.709844288 -0800
@@ -2174,24 +2174,21 @@ e1000_clean(struct net_device *netdev, i
 	int tx_cleaned;
 	int work_done = 0;
 	
-	if (!netif_carrier_ok(netdev))
-		goto quit_polling;
-
 	tx_cleaned = e1000_clean_tx_irq(adapter);
 	e1000_clean_rx_irq(adapter, &work_done, work_to_do);
 
 	*budget -= work_done;
 	netdev->quota -= work_done;
 	
-	/* if no Rx and Tx cleanup work was done, exit the polling mode */
-	if(!tx_cleaned || (work_done < work_to_do) || 
+	/* if no Tx and not enough Rx work done, exit the polling mode */
+	if((!tx_cleaned && (work_done < work_to_do)) || 
 				!netif_running(netdev)) {
-quit_polling:	netif_rx_complete(netdev);
+		netif_rx_complete(netdev);
 		e1000_irq_enable(adapter);
 		return 0;
 	}
 
-	return (work_done >= work_to_do);
+	return 1;
 }
 
 #endif
	

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net-drivers-2.6 1/10] e1000: Robert Olsson's fix and refinement to the poll routine
  2005-02-15 21:24 [PATCH net-drivers-2.6 1/10] e1000: Robert Olsson's fix and refinement to the poll routine Malli Chilakala
@ 2005-02-21  2:14 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2005-02-21  2:14 UTC (permalink / raw)
  To: Malli Chilakala; +Cc: netdev

Malli Chilakala wrote:
> 1 Robert Olsson's fix and refinement to the poll routine

applied patches 1-10 to 2.6.x.

Same comment as before:  do not include patch number in email 
description, as this must be hand-edited out of each description after 
the automated patch merge step occurs.

	Jeff

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-02-21  2:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-15 21:24 [PATCH net-drivers-2.6 1/10] e1000: Robert Olsson's fix and refinement to the poll routine Malli Chilakala
2005-02-21  2:14 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).