From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Ben Greear <greearb@candelatech.com>
Cc: robert.olsson@its.uu.se, netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] pktgen: reduce stack usage
Date: Mon, 21 Feb 2005 08:27:20 -0800 [thread overview]
Message-ID: <421A0BE8.6050603@osdl.org> (raw)
In-Reply-To: <4216AAE4.1080804@candelatech.com>
Ben Greear wrote:
> Randy.Dunlap wrote:
>
>> (resend)
>> Any comments this time?
>>
>> pktgen: proc_if_write: reduce stack usage (on i386)
>> from 776 to 296 bytes by combining/reusing locals.
>
> Since these methods are not in the fast path, and the stack
> usage is not near 4k, does this really matter?
It's not critical or near causing a stack overflow AFAICT.
And ideally gcc would recognize this kind of usage and not
allocate multiple stack entries for it.
syscall: sys_write (tiny stack usage)
-> vfs_write (tiny)
-> proc_file_write (tiny)
-> proc_if_write (pktgen: large)
> I'm asking more to be educated than to dismiss the changes....
--
~Randy
prev parent reply other threads:[~2005-02-21 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-18 21:42 [PATCH] pktgen: reduce stack usage Randy.Dunlap
2005-02-18 22:11 ` Francois Romieu
2005-02-18 22:20 ` Randy.Dunlap
2005-02-18 22:37 ` Randy.Dunlap
2005-02-21 14:13 ` Robert Olsson
2005-02-21 16:12 ` Randy.Dunlap
2005-02-22 15:41 ` Robert Olsson
2005-02-24 4:31 ` David S. Miller
2005-02-19 2:56 ` Ben Greear
2005-02-21 16:27 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421A0BE8.6050603@osdl.org \
--to=rddunlap@osdl.org \
--cc=greearb@candelatech.com \
--cc=netdev@oss.sgi.com \
--cc=robert.olsson@its.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).