netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Richard Dawe <rich@phekda.gotadsl.co.uk>, netdev@oss.sgi.com
Subject: Re: [PATCH]: r8169: Message level support
Date: Sat, 26 Feb 2005 16:20:43 -0500	[thread overview]
Message-ID: <4220E82B.6080309@pobox.com> (raw)
In-Reply-To: <20050226203518.GA14688@electric-eye.fr.zoreil.com>

Francois Romieu wrote:
> Jeff, can you send a ack/nack if you disagree with the remarks below ?
> 
> Richard Dawe <rich@phekda.gotadsl.co.uk> :
> [...]
> 
>>There seems to be a mixture of drivers using a bitfield and a level. 
>>Which is the currently preferred mechanism?
> 
> 
> They do not offer exactly the same range. I prefer to keep both as the
> module option is not that expensive.

* The preferred mechanism is to have an integer verbosity level 'debug', 
which is converted using netif_msg_init() into a bitmap.

* PFX should only be used in probe paths.  In all other cases, dev->name 
should be used.

* I strongly agree with the comment "Imho the driver should not poke its 
nose into the guts of netif_msg_xxx()"

	Jeff

  reply	other threads:[~2005-02-26 21:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-26 17:11 [PATCH]: r8169: Message level support Richard Dawe
2005-02-26 20:35 ` Francois Romieu
2005-02-26 21:20   ` Jeff Garzik [this message]
2005-02-27 22:43   ` Richard Dawe
2005-02-27 23:52     ` Francois Romieu
2005-02-28 17:27       ` [PATCH 1/2] r8169: Jumbo Frames mini-increase Jon Mason
2005-02-28 19:32         ` Francois Romieu
2005-02-28 19:41           ` Jon Mason
2005-02-28 20:19           ` Jeff Garzik
2005-02-28 20:56             ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4220E82B.6080309@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=rich@phekda.gotadsl.co.uk \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).