netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "Randy.Dunlap" <randy.dunlap@verizon.net>
Cc: netdev@oss.sgi.com, torvalds <torvalds@osdl.org>, akpm <akpm@osdl.org>
Subject: Re: [PATCH] tulip: de2104x, fix init. sections
Date: Wed, 02 Mar 2005 01:09:54 -0500	[thread overview]
Message-ID: <422558B2.6020105@pobox.com> (raw)
In-Reply-To: <20050301214438.4653810e.randy.dunlap@verizon.net>

Randy.Dunlap wrote:
> tulip/de2104x: some __devinit functions were calling __init
>   functions, made the latter __devinit also;

Should go the other way:  all the stuff in de2104x should be __init, not 
__devinit.

Nobody ever hotplugs a de2104x.

	Jeff

  reply	other threads:[~2005-03-02  6:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-02  5:44 [PATCH] tulip: de2104x, fix init. sections Randy.Dunlap
2005-03-02  6:09 ` Jeff Garzik [this message]
2005-03-02  7:02   ` Linus Torvalds
2005-03-02  7:03     ` Jeff Garzik
2005-03-02  7:14       ` Linus Torvalds
2005-03-02  7:25   ` Christoph Hellwig
2005-03-02  7:30     ` Jeff Garzik
2005-03-02  7:32       ` Christoph Hellwig
2005-03-02  7:37         ` Jeff Garzik
2005-03-02  7:41         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=422558B2.6020105@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=netdev@oss.sgi.com \
    --cc=randy.dunlap@verizon.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).