From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] tulip: de2104x, fix init. sections
Date: Wed, 02 Mar 2005 02:30:17 -0500
Message-ID: <42256B89.2000104@pobox.com>
References: <20050301214438.4653810e.randy.dunlap@verizon.net> <422558B2.6020105@pobox.com> <20050302072510.GA12464@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Randy.Dunlap" <randy.dunlap@verizon.net>, netdev@oss.sgi.com,
        torvalds <torvalds@osdl.org>, akpm <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
In-Reply-To: <20050302072510.GA12464@infradead.org>
Sender: netdev-bounce@oss.sgi.com
Errors-to: netdev-bounce@oss.sgi.com
List-Id: netdev.vger.kernel.org

Christoph Hellwig wrote:
> On Wed, Mar 02, 2005 at 01:09:54AM -0500, Jeff Garzik wrote:
> 
>>Randy.Dunlap wrote:
>>
>>>tulip/de2104x: some __devinit functions were calling __init
>>> functions, made the latter __devinit also;
>>
>>Should go the other way:  all the stuff in de2104x should be __init, not 
>>__devinit.
>>
>>Nobody ever hotplugs a de2104x.
> 
> 
> How comes that you want to dictate what cards I put into my hotplug
> PCI slots?

When someone proves this is possible, I will accept the code change.  I 
doubt this will ever happen, for two reasons:

1) Hotplug PCI slots are highly likely to choke on the 2104x's very 
early and slightly weird PCI hardware implementation.

2) It's an ancient card and nobody will ever bother trying to hotplug it.

	Jeff