From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects Date: Wed, 02 Mar 2005 14:12:04 -0500 Message-ID: <42261004.4000501@pobox.com> References: <20050223014233.6710fd73.akpm@osdl.org> <20050226113123.GJ3311@stusta.de> <42256078.1040002@pobox.com> <20050302140833.GD4608@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrew Morton , netdev@oss.sgi.com, linux-kernel@vger.kernel.org To: Adrian Bunk In-Reply-To: <20050302140833.GD4608@stusta.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Adrian Bunk wrote: > On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > >>Adrian Bunk wrote: >> >>>+ select CRYPTO >>> select CRYPTO_AES >>> ---help--- >>> Include software based cipher suites in support of IEEE 802.11i >>> (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled >>> networks. >>>@@ -54,10 +55,11 @@ >>> "ieee80211_crypt_ccmp". >>> >>>config IEEE80211_CRYPT_TKIP >>> tristate "IEEE 802.11i TKIP encryption" >>> depends on IEEE80211 >>>+ select CRYPTO >>> select CRYPTO_MICHAEL_MIC >> >> >>'select CRYPTO_AES' should 'select CRYPTO' automatically, I would hope. > > > This would result in a recursive dependency. No, it wouldn't. CRYPTO_AES depends on CRYPTO, which depends on nothing. Jeff