netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remove dead extern's in netdevice.h
@ 2005-03-02 18:59 Stephen Hemminger
  2005-03-02 21:36 ` jamal
  2005-03-10  5:14 ` David S. Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Hemminger @ 2005-03-02 18:59 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev

The following definitions are historical relics.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

diff -Nru a/include/linux/netdevice.h b/include/linux/netdevice.h
--- a/include/linux/netdevice.h	2005-03-02 10:53:22 -08:00
+++ b/include/linux/netdevice.h	2005-03-02 10:53:22 -08:00
@@ -921,8 +921,6 @@
 extern void		dev_mcast_init(void);
 extern int		netdev_max_backlog;
 extern int		weight_p;
-extern unsigned long	netdev_fc_xoff;
-extern atomic_t netdev_dropping;
 extern int		netdev_set_master(struct net_device *dev, struct net_device *master);
 extern int skb_checksum_help(struct sk_buff *skb, int inward);
 /* rx skb timestamps */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remove dead extern's in netdevice.h
  2005-03-02 18:59 [PATCH] remove dead extern's in netdevice.h Stephen Hemminger
@ 2005-03-02 21:36 ` jamal
  2005-03-02 22:40   ` Jeff Garzik
  2005-03-10  5:14 ` David S. Miller
  1 sibling, 1 reply; 4+ messages in thread
From: jamal @ 2005-03-02 21:36 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: David S. Miller, netdev, Jeff Garzik


If you want to do this, you might as well kill hardware flow control.
I dont remember what the last decision was when we last pinged people.
Jeff?

cheers,
jamal

On Wed, 2005-03-02 at 13:59, Stephen Hemminger wrote:
> The following definitions are historical relics.
> 
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> 
> diff -Nru a/include/linux/netdevice.h b/include/linux/netdevice.h
> --- a/include/linux/netdevice.h	2005-03-02 10:53:22 -08:00
> +++ b/include/linux/netdevice.h	2005-03-02 10:53:22 -08:00
> @@ -921,8 +921,6 @@
>  extern void		dev_mcast_init(void);
>  extern int		netdev_max_backlog;
>  extern int		weight_p;
> -extern unsigned long	netdev_fc_xoff;
> -extern atomic_t netdev_dropping;
>  extern int		netdev_set_master(struct net_device *dev, struct net_device *master);
>  extern int skb_checksum_help(struct sk_buff *skb, int inward);
>  /* rx skb timestamps */
> 
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remove dead extern's in netdevice.h
  2005-03-02 21:36 ` jamal
@ 2005-03-02 22:40   ` Jeff Garzik
  0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2005-03-02 22:40 UTC (permalink / raw)
  To: hadi; +Cc: Stephen Hemminger, David S. Miller, netdev

jamal wrote:
> If you want to do this, you might as well kill hardware flow control.
> I dont remember what the last decision was when we last pinged people.
> Jeff?

I'm pretty sure hw flow control is already gone...

	Jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] remove dead extern's in netdevice.h
  2005-03-02 18:59 [PATCH] remove dead extern's in netdevice.h Stephen Hemminger
  2005-03-02 21:36 ` jamal
@ 2005-03-10  5:14 ` David S. Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David S. Miller @ 2005-03-10  5:14 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

On Wed, 2 Mar 2005 10:59:02 -0800
Stephen Hemminger <shemminger@osdl.org> wrote:

> The following definitions are historical relics.
> 
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Good catch, I missed this when we ripped out the hw flow
control stuff.

Applied, thanks Stephen.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-03-10  5:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-02 18:59 [PATCH] remove dead extern's in netdevice.h Stephen Hemminger
2005-03-02 21:36 ` jamal
2005-03-02 22:40   ` Jeff Garzik
2005-03-10  5:14 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).