From: Florian Fainelli <f.fainelli@gmail.com>
To: Benjamin Poirier <bpoirier@suse.com>, David Miller <davem@davemloft.net>
Cc: Sathya Perla <sathya.perla@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Firo Yang <fyang@suse.com>, Saeed Mahameed <saeedm@mellanox.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] be2net: Synchronize be_update_queues with dev_watchdog
Date: Thu, 18 Jul 2019 10:23:46 -0700 [thread overview]
Message-ID: <42269a37-0353-29c8-ce13-51cb2feeb9af@gmail.com> (raw)
In-Reply-To: <20190718014218.16610-1-bpoirier@suse.com>
On 7/17/19 6:42 PM, Benjamin Poirier wrote:
> As pointed out by Firo Yang, a netdev tx timeout may trigger just before an
> ethtool set_channels operation is started. be_tx_timeout(), which dumps
> some queue structures, is not written to run concurrently with
> be_update_queues(), which frees/allocates those queues structures. Add some
> synchronization between the two.
>
> Message-id: <CH2PR18MB31898E033896F9760D36BFF288C90@CH2PR18MB3189.namprd18.prod.outlook.com>
> Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Would not moving the netif_tx_disable() in be_close() further up in the
function resolve that problem as well?
--
Florian
next prev parent reply other threads:[~2019-07-18 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 1:42 [PATCH net] be2net: Synchronize be_update_queues with dev_watchdog Benjamin Poirier
2019-07-18 17:23 ` Florian Fainelli [this message]
2019-07-19 5:26 ` Benjamin Poirier
2019-07-21 20:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42269a37-0353-29c8-ce13-51cb2feeb9af@gmail.com \
--to=f.fainelli@gmail.com \
--cc=ajit.khaparde@broadcom.com \
--cc=bpoirier@suse.com \
--cc=davem@davemloft.net \
--cc=fyang@suse.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).