* [PATCH] (3/12) skge: remove unneeded include's
@ 2005-03-03 19:34 Stephen Hemminger
2005-03-03 21:41 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2005-03-03 19:34 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Get rid of unnecessary include's
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- skge-2.6.11/drivers/net/skge.c.orig 2005-03-02 17:15:44.000000000 -0800
+++ skge-2.6.11/drivers/net/skge.c 2005-03-02 17:17:25.000000000 -0800
@@ -30,13 +30,10 @@
#include <linux/moduleparam.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
-#include <linux/dma-mapping.h>
#include <linux/ethtool.h>
#include <linux/pci.h>
#include <linux/if_vlan.h>
#include <linux/ip.h>
-#include <linux/udp.h>
-#include <linux/tcp.h>
#include <linux/delay.h>
#include <linux/crc32.h>
#include <asm/irq.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] (3/12) skge: remove unneeded include's
2005-03-03 19:34 [PATCH] (3/12) skge: remove unneeded include's Stephen Hemminger
@ 2005-03-03 21:41 ` Jeff Garzik
2005-03-03 21:51 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2005-03-03 21:41 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
Stephen Hemminger wrote:
> Get rid of unnecessary include's
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> --- skge-2.6.11/drivers/net/skge.c.orig 2005-03-02 17:15:44.000000000 -0800
> +++ skge-2.6.11/drivers/net/skge.c 2005-03-02 17:17:25.000000000 -0800
> @@ -30,13 +30,10 @@
> #include <linux/moduleparam.h>
> #include <linux/netdevice.h>
> #include <linux/etherdevice.h>
> -#include <linux/dma-mapping.h>
Why is this one is unnecessary?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] (3/12) skge: remove unneeded include's
2005-03-03 21:41 ` Jeff Garzik
@ 2005-03-03 21:51 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2005-03-03 21:51 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Stephen Hemminger, netdev
On Thu, Mar 03, 2005 at 04:41:04PM -0500, Jeff Garzik wrote:
> Stephen Hemminger wrote:
> >Get rid of unnecessary include's
> >
> >Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> >
> >--- skge-2.6.11/drivers/net/skge.c.orig 2005-03-02
> >17:15:44.000000000 -0800
> >+++ skge-2.6.11/drivers/net/skge.c 2005-03-02 17:17:25.000000000 -0800
> >@@ -30,13 +30,10 @@
> > #include <linux/moduleparam.h>
> > #include <linux/netdevice.h>
> > #include <linux/etherdevice.h>
> >-#include <linux/dma-mapping.h>
>
> Why is this one is unnecessary?
Becasue the driver is using the pci_ variants of the dma mapping routines,
which are in pci.h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-03 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-03 19:34 [PATCH] (3/12) skge: remove unneeded include's Stephen Hemminger
2005-03-03 21:41 ` Jeff Garzik
2005-03-03 21:51 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).