netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Thomas Graf <tgraf@suug.ch>, davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length
Date: Sat, 05 Mar 2005 02:11:20 +0100	[thread overview]
Message-ID: <42290738.6050605@trash.net> (raw)
In-Reply-To: <20050305010319.GB27804@gondor.apana.org.au>

Herbert Xu wrote:
> On Sat, Mar 05, 2005 at 01:46:42AM +0100, Patrick McHardy wrote:
> 
>>I think that would be ok. Unrelated to this: for IFA_ADDRESS we don't
>>do an exact match, perhaps we should also do this for IFA_LOCAL for
>>consistency.
> 
> 
> You mean that we do do an exact match for IFA_ADDRESS?

No, I meant that IFA_ADDRESS matches on exact prefixlen, but uses
inet_ifa_match() for comparing the addresses. In any case we should
keep the behaviour that no given prefix is a wildcard, but if a
prefix is given we could do something similar as for IFA_ADDRESS.

Regards
Patrick

  reply	other threads:[~2005-03-05  1:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04  1:20 [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length Thomas Graf
2005-03-04  8:31 ` Herbert Xu
2005-03-04 13:14   ` Thomas Graf
2005-03-04 20:40     ` Herbert Xu
2005-03-04 20:46       ` Herbert Xu
2005-03-04 23:32     ` Herbert Xu
2005-03-05  0:29       ` Thomas Graf
2005-03-05  0:31         ` Thomas Graf
2005-03-05  0:46         ` Patrick McHardy
2005-03-05  1:03           ` Herbert Xu
2005-03-05  1:11             ` Patrick McHardy [this message]
2005-03-05  1:20               ` Thomas Graf
2005-03-05  1:28                 ` Patrick McHardy
2005-03-05  0:59         ` Herbert Xu
2005-03-05 16:23           ` Thomas Graf
2005-03-05 18:30             ` Herbert Xu
2005-03-08 16:01               ` [PATCH] [NET]: Fix deletion of equal local IPv4 " Thomas Graf
2005-03-04 13:30   ` [PATCH] [NET]: Fix deletion of local " Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42290738.6050605@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).