[PATCH 1/3 XFRM]: Fix ICMP tempsel

[PATCH 1/3 XFRM]: Fix ICMP tempsel

[Patrick McHardy]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hi Dave,

there was a lot of discussion going on last time I posted these
patches, these are the patches everyone agreed on. They are based
on your 2.6.12 tree.


[-- Attachment #2: 01.diff --]
[-- Type: text/x-patch, Size: 1664 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2005/03/05 01:57:26+01:00 kaber@coreworks.de 
#   [XFRM]: Fix ICMP tempsel
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
# net/ipv6/xfrm6_state.c
#   2005/03/05 01:57:18+01:00 kaber@coreworks.de +2 -2
#   [XFRM]: Fix ICMP tempsel
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
# net/ipv4/xfrm4_state.c
#   2005/03/05 01:57:18+01:00 kaber@coreworks.de +2 -2
#   [XFRM]: Fix ICMP tempsel
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
diff -Nru a/net/ipv4/xfrm4_state.c b/net/ipv4/xfrm4_state.c
--- a/net/ipv4/xfrm4_state.c	2005-03-05 13:03:27 +01:00
+++ b/net/ipv4/xfrm4_state.c	2005-03-05 13:03:27 +01:00
@@ -20,9 +20,9 @@
 {
 	x->sel.daddr.a4 = fl->fl4_dst;
 	x->sel.saddr.a4 = fl->fl4_src;
-	x->sel.dport = fl->fl_ip_dport;
+	x->sel.dport = xfrm_flowi_dport(fl);
 	x->sel.dport_mask = ~0;
-	x->sel.sport = fl->fl_ip_sport;
+	x->sel.sport = xfrm_flowi_sport(fl);
 	x->sel.sport_mask = ~0;
 	x->sel.prefixlen_d = 32;
 	x->sel.prefixlen_s = 32;
diff -Nru a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
--- a/net/ipv6/xfrm6_state.c	2005-03-05 13:03:27 +01:00
+++ b/net/ipv6/xfrm6_state.c	2005-03-05 13:03:27 +01:00
@@ -27,9 +27,9 @@
 	 * to current session. */
 	ipv6_addr_copy((struct in6_addr *)&x->sel.daddr, &fl->fl6_dst);
 	ipv6_addr_copy((struct in6_addr *)&x->sel.saddr, &fl->fl6_src);
-	x->sel.dport = fl->fl_ip_dport;
+	x->sel.dport = xfrm_flowi_dport(fl);
 	x->sel.dport_mask = ~0;
-	x->sel.sport = fl->fl_ip_sport;
+	x->sel.sport = xfrm_flowi_sport(fl);
 	x->sel.sport_mask = ~0;
 	x->sel.prefixlen_d = 128;
 	x->sel.prefixlen_s = 128;

Re: [PATCH 1/3 XFRM]: Fix ICMP tempsel

[YOSHIFUJI Hideaki / 吉藤英明]

In article <4229BB22.50107@trash.net> (at Sat, 05 Mar 2005 14:58:58 +0100), Patrick McHardy <kaber@trash.net> says:

> there was a lot of discussion going on last time I posted these
> patches, these are the patches everyone agreed on. They are based
> on your 2.6.12 tree.

Acked-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

--yoshfuji