netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Adrian Bunk <bunk@stusta.de>,
	akpm@osdl.org, davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [patch 1/3] fix buggy IEEE80211_CRYPT_* selects
Date: Sun, 06 Mar 2005 13:00:50 -0500	[thread overview]
Message-ID: <422B4552.5000504@pobox.com> (raw)
In-Reply-To: <20050306090936.GA31890@gondor.apana.org.au>

Herbert Xu wrote:
> On Sat, Mar 05, 2005 at 12:07:18AM +0100, Adrian Bunk wrote:
> 
>>The way kconfig currently works, you have to ensure that the 
>>dependencies of what you select are fulfilled.
> 
> 
> Yes Adrian's right.  In the other places where we select CRYPTO
> symbols, we always make sure that CRYPTO itself is selected.  See
> net/ipv4/Kconfig for example.

I would rather fix Kconfig.  If we are selecting X_1 -- which explicitly 
depends on X -- when Kconfig should automatically select X.

It is completely illogical to duplicate a dependency chain each time you 
wish to select a symbol.

	Jeff

  reply	other threads:[~2005-03-06 18:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-04 12:37 [patch 1/3] fix buggy IEEE80211_CRYPT_* selects akpm
2005-03-04 17:33 ` Jeff Garzik
2005-03-04 22:10   ` Adrian Bunk
2005-03-04 22:21     ` Jeff Garzik
2005-03-04 23:07       ` Adrian Bunk
2005-03-06  9:09         ` Herbert Xu
2005-03-06 18:00           ` Jeff Garzik [this message]
2005-03-06 19:10             ` Adrian Bunk
2005-03-06 19:13               ` Jeff Garzik
2005-03-06 21:09             ` Herbert Xu
2005-03-09 20:21               ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=422B4552.5000504@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).