netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@oss.sgi.com
Subject: Re: [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles
Date: Mon, 07 Mar 2005 03:30:26 +0100	[thread overview]
Message-ID: <422BBCC2.4010706@trash.net> (raw)
In-Reply-To: <20050307015943.GA4533@gondor.apana.org.au>

Herbert Xu wrote:
> How about we fix the bundle problem first, and then add the fwmark/tos
> stuff? I think fixing the bundle list scalability is probably more
> important than having working TOS/fwmark at this point in time.

I agree that it is more important, but I don't see any harm in fixing
the other problem for transport mode first. Fixing the scalability
problem requires a dynamically resized hash, anything static will
lead to different scalability problems with a large number of policies.
The tos/fwmark part looks comparatively small, simply reroute all
packets based on src/dst/fwmark/predicted final tos if they differ.
But since both of this is not done yet, I think it would be better to
fix the smaller problem first.

Regards
Patrick

  reply	other threads:[~2005-03-07  2:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-05 13:59 [PATCH 3/3 XFRM]: Fix invalid key for lookup of cached bundles Patrick McHardy
2005-03-06 10:29 ` Herbert Xu
2005-03-06 10:54   ` Patrick McHardy
2005-03-06 12:34   ` Patrick McHardy
2005-03-06 17:55     ` Patrick McHardy
2005-03-07  1:24     ` Herbert Xu
2005-03-07  1:41       ` Patrick McHardy
2005-03-07  1:43         ` Herbert Xu
2005-03-07  1:55           ` Patrick McHardy
2005-03-07  1:59             ` Herbert Xu
2005-03-07  2:30               ` Patrick McHardy [this message]
2005-03-07  2:57                 ` Herbert Xu
2005-03-07  3:11                   ` Patrick McHardy
2005-03-15  5:51                     ` David S. Miller
2005-03-15  6:01                       ` Herbert Xu
2005-03-15  6:14                         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=422BBCC2.4010706@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).