From: Jeff Garzik <jgarzik@pobox.com>
To: "Luis R. Rodriguez" <mcgrof@ruslug.rutgers.edu>
Cc: domen@coderock.org, prism54-private@prism54.org,
netdev@oss.sgi.com, tklauser@nuerscht.ch
Subject: Re: [patch 2/3] drivers/net/wireless/prism54/islpci_hotplug: Use the DMA_{64, 32}BIT_MASK constants
Date: Mon, 07 Mar 2005 12:24:24 -0500 [thread overview]
Message-ID: <422C8E48.9000006@pobox.com> (raw)
In-Reply-To: <20050307171418.GT3936@ruslug.rutgers.edu>
Luis R. Rodriguez wrote:
> On Sun, Mar 06, 2005 at 11:23:55PM +0100, domen@coderock.org wrote:
>
>>Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h
>>when calling pci_set_dma_mask() or pci_set_consistent_dma_mask()
>>
>>Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
>>Signed-off-by: Domen Puncer <domen@coderock.org>
>>---
>>
>>
>> kj-domen/drivers/net/wireless/prism54/islpci_hotplug.c | 2 +-
>> 1 files changed, 1 insertion(+), 1 deletion(-)
>>
>>diff -puN drivers/net/wireless/prism54/islpci_hotplug.c~dma_mask-drivers_net_wireless_prism54_islpci_hotplug drivers/net/wireless/prism54/islpci_hotplug.c
>>--- kj/drivers/net/wireless/prism54/islpci_hotplug.c~dma_mask-drivers_net_wireless_prism54_islpci_hotplug 2005-03-05 16:12:02.000000000 +0100
>>+++ kj-domen/drivers/net/wireless/prism54/islpci_hotplug.c 2005-03-05 16:12:02.000000000 +0100
>>@@ -125,7 +125,7 @@ prism54_probe(struct pci_dev *pdev, cons
>> }
>>
>> /* enable PCI DMA */
>>- if (pci_set_dma_mask(pdev, 0xffffffff)) {
>>+ if (pci_set_dma_mask(pdev, DMA_32BIT_MASK)) {
>
>
> Is this 2.4 backward compatible? If not we'll have to add to 2.4 compat
> file on prism54.
Not compatible, but it is preferred to patch the file and add that
definition to a compat header.
For pci_module_init(), it is preferred to keep pci_module_init() rather
than adding compat gunk.
Jeff
next prev parent reply other threads:[~2005-03-07 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-06 22:23 [patch 2/3] drivers/net/wireless/prism54/islpci_hotplug: Use the DMA_{64, 32}BIT_MASK constants domen
2005-03-07 17:14 ` Luis R. Rodriguez
2005-03-07 17:24 ` Jeff Garzik [this message]
2005-03-07 17:29 ` Luis R. Rodriguez
2005-03-08 15:22 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422C8E48.9000006@pobox.com \
--to=jgarzik@pobox.com \
--cc=domen@coderock.org \
--cc=mcgrof@ruslug.rutgers.edu \
--cc=netdev@oss.sgi.com \
--cc=prism54-private@prism54.org \
--cc=tklauser@nuerscht.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).