From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [leo@yuriev.ru: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header] Date: Mon, 07 Mar 2005 10:13:37 -0800 Message-ID: <422C99D1.4030105@candelatech.com> References: <20050305141225.GA5180@xi.wantstofly.org> <20050307100744.429e100a@dxpl.pdx.osdl.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@oss.sgi.com To: Stephen Hemminger In-Reply-To: <20050307100744.429e100a@dxpl.pdx.osdl.net> Sender: netdev-bounce@oss.sgi.com Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org Stephen Hemminger wrote: > On Sat, 5 Mar 2005 15:12:25 +0100 > Lennert Buytenhek wrote: > > >>----- Forwarded message from Leo Yuriev ----- >> >>From: Leo Yuriev >>To: Lennert Buytenhek , >> Alexey Kuznetsov >>Cc: linux-kernel@vger.kernel.org >>Subject: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header >> >>Kernel 2.6 (2.6.11) >> >>When ethernet-bridge forward a packet and such ethernet-frame has >>VLAN-tag, bridge should update skb->prioriry for properly QoS >>handling. >> >>This small patch does this. Currently vlan_TCI-priority directly >>mapped to skb->priority, but this looks enough. > > > I don't see why the VLAN code doesn't handle this itself. I don't like special > case layer violations because it becomes a slippery slope with more and > more additions. VLAN does handle this. The main use for the patch is for bridging VLANs across a normal ethernet device, it appears. Ie, not really using the VLAN module at all. Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com